Changeset 58779 for trunk/tests/phpunit/tests/html-api/wpHtmlProcessorSemanticRules.php

Timestamp:

07/22/2024 10:22:03 PM (12 months ago)

Author:

dmsnell

Message:

HTML API: Add missing tags in IN BODY insertion mode to HTML Processor.

As part of work to add more spec support to the HTML API, this patch adds
support for the remaining missing tags in the IN BODY insertion mode. Not
all of the added tags are supported, because in some cases they reset the
insertion mode and are reprocessed where they will be rejected.

This patch also improves the support of get_modifiable_text(), removing
a leading newline inside a LISTING, PRE, or TEXTAREA element.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/6972
Discussed in https://core.trac.wordpress.org/ticket/61576

Props dmsnell, jonsurrell, westonruter.
See #61576.

File:

• trunk/tests/phpunit/tests/html-api/wpHtmlProcessorSemanticRules.php (modified) (3 diffs)

trunk/tests/phpunit/tests/html-api/wpHtmlProcessorSemanticRules.php

@@ -407 +407 @@
 
     /**
-     * Ensures that support isn't accidentally partially added for the closing BR tag `</br>`.
-     *
-     * This tag closer has special rules and support shouldn't be added without implementing full support.
+     * Ensures that closing `</br>` tags are appropriately treated as opening tags with no attributes.
      *
      * > An end tag whose tag name is "br"
@@ -416 +414 @@
      * >   tag token that it actually is.
      *
-     * When this handling is implemented, this test should be removed. It's not incorporated
-     * into the existing unsupported tag behavior test because the opening tag is supported;
-     * only the closing tag isn't.
-     *
      * @covers WP_HTML_Processor::step_in_body
      *
@@ -425 +419 @@
      */
     public function test_br_end_tag_unsupported() {
-        $processor = WP_HTML_Processor::create_fragment( '</br>' );
-
-        $this->assertFalse( $processor->next_tag(), 'Found a BR tag that should not be handled.' );
-        $this->assertSame( WP_HTML_Processor::ERROR_UNSUPPORTED, $processor->get_last_error() );
+        $processor = WP_HTML_Processor::create_fragment( '</br id="an-opener" html>' );
+
+        $this->assertTrue( $processor->next_tag(), 'Failed to find the expected opening BR tag.' );
+        $this->assertFalse( $processor->is_tag_closer(), 'Should have treated the tag as an opening tag.' );
+        $this->assertNull( $processor->get_attribute_names_with_prefix( '' ), 'Should have ignored any attributes on the tag.' );
     }
 }