Changeset 58803

Timestamp:

07/24/2024 03:08:08 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more specific assertions in get_comment_author() tests.

Follow-up to [58335].

See #61530.

File:

• trunk/tests/phpunit/tests/comment/getCommentAuthor.php (modified) (3 diffs)

trunk/tests/phpunit/tests/comment/getCommentAuthor.php

@@ -23 +23 @@
         public function get_comment_author_filter( $comment_author, $comment_id, $comment ) {
                 $this->assertSame( $comment_id, self::$comment->comment_ID, 'Comment IDs do not match.' );
-                $this->assertTrue( is_string( $comment_id ), '$comment_id parameter is not a string.' );
+                $this->assertIsString( $comment_id, '$comment_id parameter is not a string.' );
 
                 return $comment_author;
@@ -42 +42 @@
         public function get_comment_author_filter_non_existent_id( $comment_author, $comment_id, $comment ) {
                 $this->assertSame( $comment_id, (string) self::$non_existent_comment_id, 'Comment IDs do not match.' );
-                $this->assertTrue( is_string( $comment_id ), '$comment_id parameter is not a string.' );
+                $this->assertIsString( $comment_id, '$comment_id parameter is not a string.' );
 
                 return $comment_author;
@@ -72 +72 @@
                         $comment_props->user_id = $user->ID;
                 }
+
                 $comment = new WP_Comment( $comment_props );
+
                 $this->assertSame( $expected, get_comment_author( $comment ) );
         }