Changeset 58808 for branches/6.5/tests/phpunit/tests/functions.php

Timestamp:

07/25/2024 04:33:50 PM (2 years ago)

Author:

jorbin

Message:

Filesystem: Normalize allowed_files so comparison is apples to apples.

In [58470] a change was made to normalize the filename in validate_file, however this leads to instances where the list of files that are allowed aren't normalized such as in the theme editor. By normalizing the array, the comparison is apples to apples.

Reviewed by hellofromTonya.
Merges 58570 to the 6.5 branch.

Fixes #61488.
Props jorbin, hellofromtonya, swissspidy, misulicus, script2see, Presskopp, audrasjb, peterwilsoncc, siliconforks, littler.chicken, paulkevan,

Location:

branches/6.5

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/functions.php (modified) (2 diffs)

branches/6.5/tests/phpunit/tests/functions.php

@@ -1794 +1794 @@
          *
          * @ticket 42016
+         * @ticket 61488
          * @dataProvider data_validate_file
          *
@@ -1912 +1913 @@
                                 array( 'C:/WINDOWS/system32' ),
                                 2,
+                        ),
+
+                        // Windows Path with allowed file
+                        array(
+                                'Apache24\htdocs\wordpress/wp-content/themes/twentyten/style.css',
+                                array( 'Apache24\htdocs\wordpress/wp-content/themes/twentyten/style.css' ),
+                                0,
                         ),