Changeset 58845

Timestamp:

08/02/2024 11:46:45 PM (2 months ago)

Author:

dmsnell

Message:

HTML API: Fix an infinite loop in certain unclosed SCRIPT tags.

When the Tag Processor (or HTML Processor) attempts to parse certain
incomplete script tags, the parser enters an infinite loop and will
hang indefinitely. The conditions to reach this situation are:

• Input HTML ends with an open script tag.
• The final character of input is - or <.

The infinite loop was caused by the parser-advancing increment not being
called when two || OR conditions short-circuited. If the first
condition was true, the $at++ code was never reached.

This path resolves the issue.

Developed in ​https://github.com/wordpress/wordpress-develop/pull/7128
Discussed in https://core.trac.wordpress.org/ticket/61810

Follow-up to [55203].

Props: dmsnell, jonsurrell.
Fixes #61810.

Location:

trunk

Files:

• src/wp-includes/html-api/class-wp-html-tag-processor.php (modified) (1 diff)
• tests/phpunit/tests/html-api/wpHtmlTagProcessor.php (modified) (1 diff)

trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php

@@ -1432 +1432 @@
             }
 
-            // Everything of interest past here starts with "<".
-            if ( $at + 1 >= $doc_length || '<' !== $html[ $at++ ] ) {
+            if ( $at + 1 >= $doc_length ) {
+                return false;
+            }
+
+            /*
+             * Everything of interest past here starts with "<".
+             * Check this character and advance position regardless.
+             */
+            if ( '<' !== $html[ $at++ ] ) {
                 continue;
             }

trunk/tests/phpunit/tests/html-api/wpHtmlTagProcessor.php

@@ -2876 +2876 @@
         );
     }
+
+    /**
+     * Test an infinite loop bugfix in incomplete script tag parsing.
+     *
+     * @small
+     *
+     * @ticket 61810
+     */
+    public function test_script_tag_processing_no_infinite_loop_final_dash() {
+        $processor = new WP_HTML_Tag_Processor( '<script>-' );
+
+        $this->assertFalse( $processor->next_tag() );
+        $this->assertTrue( $processor->paused_at_incomplete_token() );
+    }
+
+    /**
+     * Test an infinite loop bugfix in incomplete script tag parsing.
+     *
+     * @small
+     *
+     * @ticket 61810
+     */
+    public function test_script_tag_processing_no_infinite_loop_final_left_angle_bracket() {
+        $processor = new WP_HTML_Tag_Processor( '<script><' );
+
+        $this->assertFalse( $processor->next_tag() );
+        $this->assertTrue( $processor->paused_at_incomplete_token() );
+    }
 }