Context Navigation

← Previous Change
Next Change →

resize.php

Timestamp:

08/05/2024 04:11:40 AM (2 years ago)

Author:

noisysocks

Message:

Media: Automatically convert HEIC images to JPEG

Automatically create a JPEG version of uploaded HEIC images if the server has
a version of Imagick that supports HEIC. Conversion is done silently through
the existing WP_Image_Editor infrastructure that creates multiple sizes of
uploaded images.

This allows users to view HEIC images in WP Admin and use them in their posts
and pages regardless of whether their browser supports HEIC. Browser support
for HEIC is relatively low (only Safari) while the occurrence of HEIC images is
relatively common. The original HEIC image can be downloaded via a link on
the attachment page.

Props adamsilverstein, noisysocks, swissspidy, spacedmonkey, peterwilsoncc.
Fixes #53645.

File:

: 1 edited

trunk/tests/phpunit/tests/image/resize.php (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/image/resize.php

-              r57524
+              r58849
+        }
+        /**
+         * Test resizing HEIC image.
+         *
+         * @ticket 53645
+         */
+        public function test_resize_heic() {
+                $file   = DIR_TESTDATA . '/images/test-image.heic';
+                $editor = wp_get_image_editor( $file );
+                // Check if the editor supports the HEIC mime type.
+                if ( is_wp_error( $editor ) || ! $editor->supports_mime_type( 'image/heic' ) ) {
+                        $this->markTestSkipped( 'No HEIC support in the editor engine on this system.' );
+                }
+                $image = $this->resize_helper( $file, 25, 25 );
+                list( $w, $h, $type ) = wp_getimagesize( $image );
+                unlink( $image );
+                $this->assertSame( 'test-image-25x25.jpg', wp_basename( $image ) );
+                $this->assertSame( 25, $w );
+                $this->assertSame( 25, $h );
+                $this->assertSame( IMAGETYPE_JPEG, $type );
+        }
         public function test_resize_larger() {
                 // image_resize() should refuse to make an image larger.
 …
+                }
                 return $dest_file;
+                return $saved['path'];
+        }
+}

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 58849 for trunk/tests/phpunit/tests/image/resize.php

Legend:

trunk/tests/phpunit/tests/image/resize.php

Download in other formats: