Changeset 58858

Timestamp:

08/06/2024 08:41:58 PM (18 months ago)

Author:

dmsnell

Message:

HTML API: Truncated funky comments should cause the Tag Processor to pause.

A state change was missing in the Tag Processor when the input is too short to
find a comment closer after an opened funky comment. This patch fixes a issue
where </# does not correctly report incomplete input, but </# does.

Developed in ​https://github.com/wordpress/wordpress-develop/pull/7146
Discussed in https://core.trac.wordpress.org/ticket/61831

Props: jonsurrell.
Fixes #61831.

Location:

trunk

Files:

• src/wp-includes/html-api/class-wp-html-tag-processor.php (modified) (1 diff)
• tests/phpunit/tests/html-api/wpHtmlTagProcessor.php (modified) (1 diff)

trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php

@@ -1910 +1910 @@
                 // No chance of finding a closer.
                 if ( $at + 3 > $doc_length ) {
+                    $this->parser_state = self::STATE_INCOMPLETE_INPUT;
+
                     return false;
                 }

trunk/tests/phpunit/tests/html-api/wpHtmlTagProcessor.php

@@ -2904 +2904 @@
         $this->assertTrue( $processor->paused_at_incomplete_token() );
     }
+
+    /**
+     * Test a bugfix where the input ends abruptly with a funky comment started.
+     *
+     * @ticket 61831
+     */
+    public function test_unclosed_funky_comment_input_too_short() {
+        $processor = new WP_HTML_Tag_Processor( '</#' );
+        $this->assertFalse( $processor->next_tag() );
+        $this->assertTrue( $processor->paused_at_incomplete_token() );
+    }
 }