Changeset 58867 for trunk/tests/phpunit/tests/html-api/wpHtmlTagProcessor-token-scanning.php

Timestamp:

08/08/2024 07:23:53 AM (15 months ago)

Author:

dmsnell

Message:

HTML API: Add support for SVG and MathML (Foreign content)

As part of work to add more spec support to the HTML API, this patch adds
support for SVG and MathML elements, or more generally, "foreign content."

The rules in foreign content are a mix of XML and HTML parsing rules and
introduce additional complexity into the processor, but is important in
order to avoid getting lost when inside these elements.

Developed in ​https://github.com/wordpress/wordpress-develop/pull/6006
Discussed in https://core.trac.wordpress.org/ticket/61576

Props: dmsnell, jonsurrell, westonruter.
See #61576.

File:

• trunk/tests/phpunit/tests/html-api/wpHtmlTagProcessor-token-scanning.php (modified) (1 diff)

trunk/tests/phpunit/tests/html-api/wpHtmlTagProcessor-token-scanning.php

@@ -514 +514 @@
 
     /**
+     * Ensures that basic CDATA sections inside foreign content are detected.
+     *
+     * @ticket 61576
+     */
+    public function test_basic_cdata_in_foreign_content() {
+        $processor = new WP_HTML_Tag_Processor( '<svg><![CDATA[this is >&gt; real CDATA]]></svg>' );
+        $processor->next_token();
+
+        // Artificially change namespace; this should be done in the HTML Processor.
+        $processor->change_parsing_namespace( 'svg' );
+        $processor->next_token();
+
+        $this->assertSame(
+            '#cdata-section',
+            $processor->get_token_name(),
+            "Should have found a CDATA section but found {$processor->get_token_name()} instead."
+        );
+
+        $this->assertNull(
+            $processor->get_tag(),
+            'Should not have been able to query tag name on non-element token.'
+        );
+
+        $this->assertNull(
+            $processor->get_attribute( 'type' ),
+            'Should not have been able to query attributes on non-element token.'
+        );
+
+        $this->assertSame(
+            'this is >&gt; real CDATA',
+            $processor->get_modifiable_text(),
+            'Found incorrect modifiable text.'
+        );
+    }
+
+    /**
+     * Ensures that empty CDATA sections inside foreign content are detected.
+     *
+     * @ticket 61576
+     */
+    public function test_empty_cdata_in_foreign_content() {
+        $processor = new WP_HTML_Tag_Processor( '<svg><![CDATA[]]></svg>' );
+        $processor->next_token();
+
+        // Artificially change namespace; this should be done in the HTML Processor.
+        $processor->change_parsing_namespace( 'svg' );
+        $processor->next_token();
+
+        $this->assertSame(
+            '#cdata-section',
+            $processor->get_token_name(),
+            "Should have found a CDATA section but found {$processor->get_token_name()} instead."
+        );
+
+        $this->assertEmpty(
+            $processor->get_modifiable_text(),
+            'Found non-empty modifiable text.'
+        );
+    }
+
+    /**
      * Ensures that normative Processing Instruction nodes are properly parsed.
      *