Changeset 58892

Timestamp:

08/13/2024 09:42:07 PM (5 weeks ago)

Author:

dmsnell

Message:

HTML API: Remove unnecessary skips in tests for unsupported markup.

The HTML API allowed tests to be skipped for unsupported HTML, for example tags that had not yet been implemented. This provided stability to the test suite while primary support was being added.

In many places, the tags are now fully supported and the test skips can be removed.

Developed in ​https://github.com/wordpress/wordpress-develop/pull/7186
Discussed in https://core.trac.wordpress.org/ticket/61646

Props jonsurrell.
See #61646.

File:

• trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php (modified) (3 diffs)

trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php

@@ -156 +156 @@
         $found_tag = $processor->next_tag();
 
-        if ( WP_HTML_Processor::ERROR_UNSUPPORTED === $processor->get_last_error() ) {
-            $this->markTestSkipped( "Tag {$tag_name} is not supported." );
-        }
-
         $this->assertTrue(
             $found_tag,
@@ -220 +216 @@
         $processor   = WP_HTML_Processor::create_fragment( $self_contained_token );
         $found_token = $processor->next_token();
-
-        if ( WP_HTML_Processor::ERROR_UNSUPPORTED === $processor->get_last_error() ) {
-            $this->markTestSkipped( "HTML '{$self_contained_token}' is not supported." );
-        }
 
         $this->assertTrue(
@@ -305 +297 @@
 
         $found_tag = $processor->next_token();
-
-        if ( WP_HTML_Processor::ERROR_UNSUPPORTED === $processor->get_last_error() ) {
-            $this->markTestSkipped( "Tag {$tag_name} is not supported." );
-        }
 
         $this->assertTrue(