Changeset 58894

Timestamp:

08/13/2024 11:35:51 PM (8 weeks ago)

Author:

peterwilsoncc

Message:

Bulk/Quick Edit: Remove duplicate HTML IDs from post list tables.

Removes duplicate IDs on the post list admin pages affecting various list items, selects and checkboxes:

• JavaScript duplication of the inline editing HTML for bulk editing renames various IDs to include the prefix bulk-edit-,
• IDs in the Category Checkbox Walker make use of wp_unique_prefixed_id() to avoid duplicates, resulting in a numeric suffix, and,
• the post parent dropdown for the bulk editor is given a custom ID bulk_edit_post_parent.

Props peterwilsoncc, sergeybiryukov, azaozz, joedolson, siliconforks, zodiac1978, rcreators.
Fixes #61014.

Location:

trunk/src

Files:

• js/_enqueues/admin/inline-edit-post.js (modified) (1 diff)
• wp-admin/css/list-tables.css (modified) (1 diff)
• wp-admin/includes/class-walker-category-checklist.php (modified) (1 diff)
• wp-admin/includes/class-wp-posts-list-table.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/inline-edit-post.js

@@ -129 +129 @@
         });
 
+        // Clone quick edit categories for the bulk editor.
+        var beCategories = $( '#inline-edit fieldset.inline-edit-categories' ).clone();
+
+        // Make "id" attributes globally unique.
+        beCategories.find( '*[id]' ).each( function() {
+            this.id = 'bulk-edit-' + this.id;
+        });
+
         $('#bulk-edit').find('fieldset:first').after(
-            $('#inline-edit fieldset.inline-edit-categories').clone()
+            beCategories
         ).siblings( 'fieldset:last' ).prepend(
             $( '#inline-edit .inline-edit-tags-wrap' ).clone()

trunk/src/wp-admin/css/list-tables.css

@@ -1132 +1132 @@
 }
 
-.inline-edit-row #post_parent,
+.inline-edit-row select[name="post_parent"],
 .inline-edit-row select[name="page_template"] {
     max-width: 80%;

trunk/src/wp-admin/includes/class-walker-category-checklist.php

@@ -108 +108 @@
                 esc_html( apply_filters( 'the_category', $category->name, '', '' ) ) . '</div>';
         } else {
-            $is_selected = in_array( $category->term_id, $args['selected_cats'], true );
-            $is_disabled = ! empty( $args['disabled'] );
+            $is_selected         = in_array( $category->term_id, $args['selected_cats'], true );
+            $is_disabled         = ! empty( $args['disabled'] );
+            $li_element_id       = wp_unique_prefixed_id( "in-{$taxonomy}-{$category->term_id}-" );
+            $checkbox_element_id = wp_unique_prefixed_id( "in-{$taxonomy}-{$category->term_id}-" );
 
-            $output .= "\n<li id='{$taxonomy}-{$category->term_id}'$class>" .
-                '<label class="selectit"><input value="' . $category->term_id . '" type="checkbox" name="' . $name . '[]" id="in-' . $taxonomy . '-' . $category->term_id . '"' .
+            $output .= "\n<li id='" . esc_attr( $li_element_id ) . "'$class>" .
+                '<label class="selectit"><input value="' . $category->term_id . '" type="checkbox" name="' . $name . '[]" id="' . esc_attr( $checkbox_element_id ) . '"' .
                 checked( $is_selected, true, false ) .
                 disabled( $is_disabled, true, false ) . ' /> ' .

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1843 +1843 @@
                             if ( $bulk ) {
                                 $dropdown_args['show_option_no_change'] = __( '— No Change —' );
+                                $dropdown_args['id']                    = 'bulk_edit_post_parent';
                             }