Changeset 58906 for trunk/src/wp-includes/update.php

Timestamp:

08/17/2024 07:52:46 PM (7 weeks ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Remove the return value of _wp_delete_all_temp_backups().

This function is only utilized as a shutdown action callback, so the return value is not used anywhere.

wp_trigger_error() is now used instead under the same conditions.

Follow-up to [55720], [56342].

Props johnbillion, amitraj2203, narenin.
Fixes #61116.

File:

• trunk/src/wp-includes/update.php (modified) (2 diffs)

trunk/src/wp-includes/update.php

@@ -1100 +1100 @@
  *
  * @global WP_Filesystem_Base $wp_filesystem WordPress filesystem subclass.
- *
- * @return void|WP_Error Void on success, or a WP_Error object on failure.
  */
 function _wp_delete_all_temp_backups() {
@@ -1115 +1113 @@
 
     if ( false === $credentials || ! WP_Filesystem( $credentials ) ) {
-        return new WP_Error( 'fs_unavailable', __( 'Could not access filesystem.' ) );
+        wp_trigger_error( __FUNCTION__, __( 'Could not access filesystem.' ) );
+        return;
     }
 
     if ( ! $wp_filesystem->wp_content_dir() ) {
-        return new WP_Error(
-            'fs_no_content_dir',
+        wp_trigger_error(
+            __FUNCTION__,
             /* translators: %s: Directory name. */
             sprintf( __( 'Unable to locate WordPress content directory (%s).' ), 'wp-content' )
         );
+        return;
     }