Changeset 58912 for trunk/tests/phpunit/tests/privacy/wpPrivacySendRequestConfirmationNotification.php

Timestamp:

08/18/2024 11:43:37 PM (7 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Bring some consistency to personal data email notification tests.

Includes:

• Adding a test for wp_privacy_send_personal_data_export_email() to verify the user_request post type.
• Reordering some pre-existing tests to check the request ID and post type first.

Follow-up to [43291], [43499], [44535].

Props garrett-eclipse, berubenic.
See #46560.

File:

• trunk/tests/phpunit/tests/privacy/wpPrivacySendRequestConfirmationNotification.php (modified) (5 diffs)

trunk/tests/phpunit/tests/privacy/wpPrivacySendRequestConfirmationNotification.php

@@ -33 +33 @@
 
     /**
-     * The function should not send emails when the request ID does not exist.
-     *
-     * @ticket 43967
-     */
-    public function test_function_should_not_send_email_when_not_a_valid_request_id() {
+     * The function should not send an email when the request ID does not exist.
+     *
+     * @ticket 43967
+     */
+    public function test_should_not_send_email_when_not_a_valid_request_id() {
         _wp_privacy_send_request_confirmation_notification( 1234567890 );
         $mailer = tests_retrieve_phpmailer_instance();
@@ -45 +45 @@
 
     /**
-     * The function should not send emails when the ID passed is not a WP_User_Request.
-     *
-     * @ticket 43967
-     */
-    public function test_function_should_not_send_email_when_not_a_wp_user_request() {
+     * The function should not send an email when the ID passed does not correspond to a user request.
+     *
+     * @ticket 43967
+     */
+    public function test_should_not_send_email_when_not_a_user_request() {
         $post_id = self::factory()->post->create(
             array(
-                'post_type' => 'post',
+                'post_type' => 'post', // Should be 'user_request'.
             )
         );
@@ -67 +67 @@
      * @ticket 43967
      */
-    public function test_function_should_send_email_to_site_admin_when_user_request_confirmed() {
+    public function test_should_send_email_to_site_admin_when_user_request_confirmed() {
         $email      = 'export.request.from.unregistered.user@example.com';
         $request_id = wp_create_user_request( $email, 'export_personal_data' );
@@ -90 +90 @@
      * @ticket 43967
      */
-    public function test_function_should_only_send_email_to_site_admin_when_user_request_is_confirmed() {
+    public function test_should_only_send_email_to_site_admin_when_user_request_is_confirmed() {
         $email      = 'export.request.from.unregistered.user@example.com';
         $request_id = wp_create_user_request( $email, 'export_personal_data' );
@@ -110 +110 @@
      * @ticket 43967
      */
-    public function test_function_should_only_send_email_once_to_admin_when_user_request_is_confirmed() {
+    public function test_should_only_send_email_once_to_admin_when_user_request_is_confirmed() {
         $email      = 'export.request.from.unregistered.user@example.com';
         $request_id = wp_create_user_request( $email, 'export_personal_data' );