Changeset 58918

Timestamp:

08/20/2024 05:48:07 PM (3 weeks ago)

Author:

SergeyBiryukov

Message:

Taxonomy: Correct the check for error messages in wp-admin/edit-tag-form.php.

Instead of checking for a specific message, e.g. “Item not updated”, the $_REQUEST['error'] variable is now checked. This allows for custom messages added via the term_updated_messages filter to be considered an error when appropriate, and displayed with the correct CSS class.

This also brings consistency with a similar check in wp-admin/edit-tags.php.

Follow-up to [31823], [44663].

Props xipasduarte.
Fixes #61896.

Location:

trunk/src/wp-admin

Files:

• edit-tag-form.php (modified) (2 diffs)
• edit-tags.php (modified) (3 diffs)

trunk/src/wp-admin/edit-tag-form.php

@@ -73 +73 @@
 
 <?php
-$class = ( isset( $msg ) && 5 === $msg ) ? 'error' : 'success';
+$class = ( isset( $_REQUEST['error'] ) ) ? 'error' : 'success';
 
 if ( $message ) {
@@ -84 +84 @@
         );
     }
+
     wp_admin_notice(
         $message,

trunk/src/wp-admin/edit-tags.php

@@ -322 +322 @@
 require_once ABSPATH . 'wp-admin/includes/edit-tag-messages.php';
 
-$class = ( isset( $_REQUEST['error'] ) ) ? 'error' : 'updated';
-
 if ( is_plugin_active( 'wpcat2tag-importer/wpcat2tag-importer.php' ) ) {
     $import_link = admin_url( 'admin.php?import=wpcat2tag' );
@@ -350 +348 @@
 
 <?php
-if ( $message ) :
+$class = ( isset( $_REQUEST['error'] ) ) ? 'error' : 'updated';
+
+if ( $message ) {
     wp_admin_notice(
         $message,
@@ -359 +359 @@
         )
     );
+
     $_SERVER['REQUEST_URI'] = remove_query_arg( array( 'message', 'error' ), $_SERVER['REQUEST_URI'] );
-endif;
+}
 ?>
 <div id="ajax-response"></div>