Changeset 58932

Timestamp:

08/25/2024 10:46:43 PM (3 weeks ago)

Author:

SergeyBiryukov

Message:

Script Loader: Do not normalize absolute paths in inline block styles CSS.

_wp_normalize_relative_css_links() used to normalize all non-absolute URLs regardless of whether it's a relative path or an absolute path. The normalization should only happen for relative paths (paths without a leading /) and not for absolute paths.

Reference: ​RFC 1808, Section 4, Step 4.

Follow-up to [52036], [52695], [52754], [55658], [55669].

Props scholdstrom.
Fixes #61909.

Location:

trunk

Files:

• src/wp-includes/script-loader.php (modified) (1 diff)
• tests/phpunit/tests/dependencies/styles.php (modified) (1 diff)

trunk/src/wp-includes/script-loader.php

@@ -3057 +3057 @@
                 str_starts_with( $url, 'http:' ) ||
                 str_starts_with( $url, 'https:' ) ||
-                str_starts_with( $url, '//' ) ||
+                str_starts_with( $url, '/' ) ||
                 str_starts_with( $url, '#' ) ||
                 str_starts_with( $url, 'data:' )

trunk/tests/phpunit/tests/dependencies/styles.php

@@ -229 +229 @@
                 'expected' => 'p {background-image: url(\'/wp-content/themes/test/../image1.jpg\');}',
             ),
+            'URLs with absolute path, shouldn\'t change'   => array(
+                'css'      => 'p {background:url( "/image0.svg" );}',
+                'expected' => 'p {background:url( "/image0.svg" );}',
+            ),
             'External URLs, shouldn\'t change'             => array(
                 'css'      => 'p {background-image: url(\'http://foo.com/image2.png\');}',