Changeset 58945 for trunk/tests/phpunit/tests/option/wpSetOptionAutoload.php

Timestamp:

08/28/2024 04:39:30 PM (20 months ago)

Author:

flixos90

Message:

Options, Meta APIs: Stop using 'yes' and 'no' for autoload parameter in favor of recommended boolean.

This changeset does not modify any behavior, it only updates the code to use the recommended type for the $autoload parameter as of WordPress 6.6. The old values 'yes' and 'no' are only maintained in certain tests that are explicitly about these backward compatibility values.

Props flixos90, joemcgill, mukesh27.
Fixes #61939.
See #61103, #61929.

File:

• trunk/tests/phpunit/tests/option/wpSetOptionAutoload.php (modified) (4 diffs)

trunk/tests/phpunit/tests/option/wpSetOptionAutoload.php

@@ -11 +11 @@
     /**
      * Tests that setting an option's autoload value to 'yes' works as expected.
+     *
+     * The values 'yes' and 'no' are only supported for backward compatibility.
      *
      * @ticket 58964
@@ -30 +32 @@
     /**
      * Tests that setting an option's autoload value to 'no' works as expected.
+     *
+     * The values 'yes' and 'no' are only supported for backward compatibility.
      *
      * @ticket 58964
@@ -57 +61 @@
         $value  = 'value';
 
-        add_option( $option, $value, '', 'yes' );
+        add_option( $option, $value, '', true );
 
-        $this->assertFalse( wp_set_option_autoload( $option, 'yes' ), 'Function did unexpectedly succeed' );
+        $this->assertFalse( wp_set_option_autoload( $option, true ), 'Function did unexpectedly succeed' );
         $this->assertSame( 'on', $wpdb->get_var( $wpdb->prepare( "SELECT autoload FROM $wpdb->options WHERE option_name = %s", $option ) ), 'Option autoload value unexpectedly updated in database' );
     }
@@ -73 +77 @@
         $option = 'test_option';
 
-        $this->assertFalse( wp_set_option_autoload( $option, 'yes' ), 'Function did unexpectedly succeed' );
+        $this->assertFalse( wp_set_option_autoload( $option, true ), 'Function did unexpectedly succeed' );
         $this->assertNull( $wpdb->get_var( $wpdb->prepare( "SELECT autoload FROM $wpdb->options WHERE option_name = %s", $option ) ), 'Missing option autoload value was set in database' );
         $this->assertArrayNotHasKey( $option, wp_cache_get( 'alloptions', 'options' ), 'Missing option found in alloptions cache' );