Changeset 58966

Timestamp:

09/02/2024 09:52:34 PM (6 weeks ago)

Author:

dmsnell

Message:

HTML API: Fix logic bug in HTML Processor when opening A element.

A mistake in the original code handling opening A elements in the HTML Processor led to mistakes in parsing where the Processor would bail in situations when it could have proceeded. While this was errant behavior, it didn't violate the public contract since it would bail in these situations.

This patch fixes the mistake, which was to only break out of the innermost loop instead of breaking from the containing loop, which resolves the issue.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/7281
Discussed in https://core.trac.wordpress.org/ticket/61576

Follow-up to [56274].

Props jonsurrell.
See #61576.

File:

• trunk/src/wp-includes/html-api/class-wp-html-processor.php (modified) (2 diffs)

trunk/src/wp-includes/html-api/class-wp-html-processor.php

@@ -2353 +2353 @@
                     switch ( $item->node_name ) {
                         case 'marker':
-                            break;
+                            break 2;
 
                         case 'A':
@@ -2359 +2359 @@
                             $this->state->active_formatting_elements->remove_node( $item );
                             $this->state->stack_of_open_elements->remove_node( $item );
-                            break;
+                            break 2;
                     }
                 }