Changeset 58974

Timestamp:

09/03/2024 05:05:33 PM (5 weeks ago)

Author:

flixos90

Message:

Media: Consistently pass 'src' attribute to wp_get_loading_optimization_attributes().

A common use-case for the 'wp_get_loading_optimization_attributes' filter is to modify attributes based on the 'src' attribute. However, the wp_img_tag_add_loading_optimization_attrs() was not passing that attribute to the function as expected, which would make such usage of the filter unreliable. This changeset ensures the 'src' attribute is also passed in this scenario. All other calls to wp_get_loading_optimization_attributes() already included the attribute.

Props deepakrohilla, prestonwordsworth, mukesh27, adamsilverstein, joemcgill, flixos90.
Fixes #61436.
See #58893.

Location:

trunk

Files:

• src/wp-includes/media.php (modified) (2 diffs)
• tests/phpunit/tests/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -1974 +1974 @@
  */
 function wp_img_tag_add_loading_optimization_attrs( $image, $context ) {
+    $src               = preg_match( '/ src=["\']?([^"\']*)/i', $image, $matche_src ) ? $matche_src[1] : null;
     $width             = preg_match( '/ width=["\']([0-9]+)["\']/', $image, $match_width ) ? (int) $match_width[1] : null;
     $height            = preg_match( '/ height=["\']([0-9]+)["\']/', $image, $match_height ) ? (int) $match_height[1] : null;
@@ -1988 +1989 @@
         'img',
         array(
+            'src'           => $src,
             'width'         => $width,
             'height'        => $height,

trunk/tests/phpunit/tests/media.php

@@ -5580 +5580 @@
 
     /**
+     * Tests that wp_img_tag_add_loading_optimization_attrs() passes the 'src' attribute to wp_get_loading_optimization_attributes().
+     *
+     * @ticket 61436
+     *
+     * @covers ::wp_img_tag_add_loading_optimization_attrs
+     */
+    public function test_wp_img_tag_add_loading_optimization_attrs_passes_src() {
+        add_filter(
+            'wp_get_loading_optimization_attributes',
+            static function ( $loading_attrs, $tag_name, $attr ) {
+                if (
+                    'img' === $tag_name &&
+                    isset( $attr['src'] ) &&
+                    'https://example.org/a-specific-image.jpg' === $attr['src']
+                ) {
+                    $loading_attrs['fetchpriority'] = 'low';
+                    $loading_attrs['loading']       = 'eager';
+                }
+                return $loading_attrs;
+            },
+            10,
+            3
+        );
+
+        $image    = '<img src="https://example.org/a-specific-image.jpg" width="1280" height="720">';
+        $expected = '<img fetchpriority="low" loading="eager" decoding="async" src="https://example.org/a-specific-image.jpg" width="1280" height="720">';
+
+        // Ensure attributes are modified because image src was matched.
+        $this->assertSame(
+            $expected,
+            wp_img_tag_add_loading_optimization_attrs( $image, 'the_content' ),
+            'fetchpriority should be low when src is matched.'
+        );
+    }
+
+    /**
      * @ticket 58235
      *