Changeset 58975 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

09/03/2024 06:17:19 PM (6 weeks ago)

Author:

flixos90

Message:

Options, Meta APIs: Explicitly pass $autoload parameter to when potentially adding new options.

It is recommended that for every option it is explicitly set whether to autoload it or not. This changeset updates relevant update_option() and add_option() calls.

Note that the $autoload parameter is only needed for update_option() if the option is potentially not present yet, i.e. the call will pass through to add_option(). Since WordPress core adds the majority of its options to the database during installation, only update_option() calls for dynamically added options need to be modified, which is what this changeset does.

As part of revisiting the autoload values for dynamically added WordPress core options, this changeset modifies some options to no longer be autoloaded, since they are only accessed in a few specific places that are not relevant for a regular request. These options are:

• recently_activated
• _wp_suggested_policy_text_has_changed
• {upgradeLock}.lock
• dashboard_widget_options
• ftp_credentials
• adminhash
• nav_menu_options
• wp_force_deactivated_plugins
• delete_blog_hash
• allowedthemes
• {sessionId}_paused_extensions
• recovery_keys
• https_detection_errors
• fresh_site

An upgrade routine is present as well that sets those options to no longer autoload for existing sites.

Props pbearne, flixos90, mukesh27, swissspidy, SergeyBiryukov, joemcgill, adamsilverstein.
Fixes #61103.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (4 diffs)

trunk/src/wp-admin/includes/upgrade.php

@@ -76 +76 @@
 
         // Freshness of site - in the future, this could get more specific about actions taken, perhaps.
-        update_option( 'fresh_site', 1 );
+        update_option( 'fresh_site', 1, false );
 
         if ( $language ) {
@@ -864 +864 @@
     }
 
+    if ( $wp_current_db_version < 58975 ) {
+        upgrade_670();
+    }
     maybe_disable_link_manager();
 
@@ -990 +993 @@
     $time_difference = $all_options->time_difference;
 
-        $server_time = time() + gmdate( 'Z' );
+    $server_time     = time() + gmdate( 'Z' );
     $weblogger_time  = $server_time + $time_difference * HOUR_IN_SECONDS;
     $gmt_time        = time();
@@ -2398 +2401 @@
     }
 }
-
+/**
+ * Executes changes made in WordPress 6.7.0.
+ *
+ * @ignore
+ * @since 6.7.0
+ *
+ * @global int  $wp_current_db_version The old (current) database version.
+ */
+function upgrade_670() {
+    global $wp_current_db_version;
+
+    if ( $wp_current_db_version < 58975 ) {
+        $options = array(
+            'recently_activated',
+            '_wp_suggested_policy_text_has_changed',
+            'dashboard_widget_options',
+            'ftp_credentials',
+            'adminhash',
+            'nav_menu_options',
+            'wp_force_deactivated_plugins',
+            'delete_blog_hash',
+            'allowedthemes',
+            'recovery_keys',
+            'https_detection_errors',
+            'fresh_site',
+        );
+
+        wp_set_options_autoload( $options, false );
+    }
+}
 /**
  * Executes network-level upgrade routines.