Changeset 58981

Timestamp:

09/03/2024 08:34:35 PM (4 weeks ago)

Author:

joedolson

Message:

Comments: Limit comments shortcut to not execute on links.

Exclude links from activating the comment submission shortcut.

[45790] introduced a shortcut to submit comment forms using Ctrl/Cmd + Enter. This keyboard combination is also the combination for opening a link in a new tab, which resulted in submitting the form when using the Log Out or Edit Profile links.

Props greentreefrog, sabernhardt, narenin.
Fixes #61919.

File:

• trunk/src/js/_enqueues/lib/comment-reply.js (modified) (1 diff)

trunk/src/js/_enqueues/lib/comment-reply.js

@@ -99 +99 @@
         // Submit the comment form when the user types [Ctrl] or [Cmd] + [Enter].
         var submitFormHandler = function( e ) {
-            if ( ( e.metaKey || e.ctrlKey ) && e.keyCode === 13 ) {
+            if ( ( e.metaKey || e.ctrlKey ) && e.keyCode === 13 && document.activeElement.tagName.toLowerCase() !== 'a' ) {
                 commentFormElement.removeEventListener( 'keydown', submitFormHandler );
                 e.preventDefault();