Changeset 58983 for trunk/src/wp-admin/includes/post.php

Timestamp:

09/03/2024 10:41:06 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Check if the post type exists in _admin_notice_post_locked().

This adds a guard to verify the result of get_post_type_object() before retrieving the all_items label, as the function returns null if the post type does not exist.

Follow-up to [24527].

Props pcarvalho, akshat280, mukesh27, SergeyBiryukov.
Fixes #60947.

File:

• trunk/src/wp-admin/includes/post.php (modified) (2 diffs)

trunk/src/wp-admin/includes/post.php

@@ -1805 +1805 @@
         }
 
-        $sendback = wp_get_referer();
-        if ( $locked && $sendback && ! str_contains( $sendback, 'post.php' ) && ! str_contains( $sendback, 'post-new.php' ) ) {
-
-                $sendback_text = __( 'Go back' );
-        } else {
+        $sendback      = wp_get_referer();
+        $sendback_text = __( 'Go back' );
+
+        if ( ! $locked || ! $sendback || str_contains( $sendback, 'post.php' ) || str_contains( $sendback, 'post-new.php' ) ) {
                 $sendback = admin_url( 'edit.php' );
 
@@ -1816 +1815 @@
                 }
 
-                $sendback_text = get_post_type_object( $post->post_type )->labels->all_items;
+                $post_type_object = get_post_type_object( $post->post_type );
+
+                if ( $post_type_object ) {
+                        $sendback_text = $post_type_object->labels->all_items;
+                }
         }