Changeset 58998

Timestamp:

09/08/2024 07:16:07 PM (5 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-includes/capabilities.php.

Follow-up to [2703], [3297], [3513], [6697], [14189], [25177], [27390], [38378], [38698], [39588], [48356], [48664].

Props aristath, poena, afercia, SergeyBiryukov.
See #61607.

File:

• trunk/src/wp-includes/capabilities.php (modified) (7 diffs)

trunk/src/wp-includes/capabilities.php

@@ -48 +48 @@
         case 'remove_user':
             // In multisite the user must be a super admin to remove themselves.
-            if ( isset( $args[0] ) && $user_id == $args[0] && ! is_super_admin( $user_id ) ) {
+            if ( isset( $args[0] ) && $user_id === (int) $args[0] && ! is_super_admin( $user_id ) ) {
                 $caps[] = 'do_not_allow';
             } else {
@@ -61 +61 @@
         case 'edit_users':
             // Allow user to edit themselves.
-            if ( 'edit_user' === $cap && isset( $args[0] ) && $user_id == $args[0] ) {
+            if ( 'edit_user' === $cap && isset( $args[0] ) && $user_id === (int) $args[0] ) {
                 break;
             }
@@ -104 +104 @@
             }
 
-            if ( ( get_option( 'page_for_posts' ) == $post->ID ) || ( get_option( 'page_on_front' ) == $post->ID ) ) {
+            if ( (int) get_option( 'page_for_posts' ) === $post->ID
+                || (int) get_option( 'page_on_front' ) === $post->ID
+            ) {
                 $caps[] = 'manage_options';
                 break;
@@ -138 +140 @@
 
             // If the post author is set and the user is the author...
-            if ( $post->post_author && $user_id == $post->post_author ) {
+            if ( $post->post_author && $user_id === (int) $post->post_author ) {
                 // If the post is published or scheduled...
                 if ( in_array( $post->post_status, array( 'publish', 'future' ), true ) ) {
@@ -241 +243 @@
 
             // If the post author is set and the user is the author...
-            if ( $post->post_author && $user_id == $post->post_author ) {
+            if ( $post->post_author && $user_id === (int) $post->post_author ) {
                 // If the post is published or scheduled...
                 if ( in_array( $post->post_status, array( 'publish', 'future' ), true ) ) {
@@ -363 +365 @@
             }
 
-            if ( $post->post_author && $user_id == $post->post_author ) {
+            if ( $post->post_author && $user_id === (int) $post->post_author ) {
                 $caps[] = $post_type->cap->read;
             } elseif ( $status_obj->private ) {
@@ -731 +733 @@
 
             if ( 'delete_term' === $cap
-                && ( get_option( 'default_' . $term->taxonomy ) == $term->term_id
-                    || get_option( 'default_term_' . $term->taxonomy ) == $term->term_id )
+                && ( (int) get_option( 'default_' . $term->taxonomy ) === $term->term_id
+                    || (int) get_option( 'default_term_' . $term->taxonomy ) === $term->term_id )
             ) {
                 $caps[] = 'do_not_allow';