Changeset 59040

Timestamp:

09/17/2024 11:22:43 PM (2 years ago)

Author:

kadamwhite

Message:

REST API: Allow posts to be published with a publication date of midnight 1970-01-01.

Explicitly checks date parsing return values for false, so that 0 (the value returned for the UNIX epoch of 1970-01-01 00:00:00) is correctly treated as a valid timestamp.

It should be valid to create a post dated to any point in history.

Props emmanuel78, sabernhardt, siliconforks, drjosh07, antpb, TimothyBlynJacobs.
Fixes #60184.

Location:

trunk

Files:

• src/wp-includes/rest-api.php (modified) (3 diffs)
• tests/phpunit/tests/rest-api/rest-schema-validation.php (modified) (1 diff)

trunk/src/wp-includes/rest-api.php

@@ -1305 +1305 @@
  * Parses an RFC3339 time into a Unix timestamp.
  *
+ * Explicitly check for `false` to detect failure, as zero is a valid return
+ * value on success.
+ *
  * @since 4.4.0
  *
@@ -1370 +1373 @@
         $date = rest_parse_date( $date );
 
-        if ( empty( $date ) ) {
+        if ( false === $date ) {
                 return null;
         }
@@ -2260 +2263 @@
 
                         case 'date-time':
-                                if ( ! rest_parse_date( $value ) ) {
+                                if ( false === rest_parse_date( $value ) ) {
                                         return new WP_Error( 'rest_invalid_date', __( 'Invalid date.' ) );
                                 }

trunk/tests/phpunit/tests/rest-api/rest-schema-validation.php

@@ -1019 +1019 @@
                 $this->assertWPError( $error );
                 $this->assertSame( 'Invalid date.', $error->get_error_message() );
+        }
+
+        /**
+         * @ticket 60184
+         */
+        public function test_epoch() {
+                $schema = array(
+                        'type'   => 'string',
+                        'format' => 'date-time',
+                );
+                $this->assertTrue( rest_validate_value_from_schema( '1970-01-01T00:00:00Z', $schema ) );
         }