Changeset 59058

Timestamp:

09/18/2024 06:44:15 PM (7 months ago)

Author:

hellofromTonya

Message:

Code Modernization: Explicitly declare all properties in AtomParser.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

There are a number of ways to mitigate this:

• If it's an accidental typo for a declared property: fix the typo.
• For known properties: declare them on the class.
• For unknown properties: add the magic __get(), __set() et al methods to the class or let the class extend stdClass which has highly optimized versions of these magic methods build in.
• For unknown _use of_ dynamic properties, the #[AllowDynamicProperties] attribute can be added to the class. The attribute will automatically be inherited by child classes.

In this case, the property added are explicitly referenced in this class, so fall in the "known property" category.

Refs:

• ​https://wiki.php.net/rfc/deprecate_dynamic_properties

Props jrf.
See #56034.

File:

• trunk/src/wp-includes/atomlib.php (modified) (1 diff)

trunk/src/wp-includes/atomlib.php

@@ -87 +87 @@
     var $feed;
     var $current;
+    var $map_attrs_func;
+    var $map_xmlns_func;
+    var $error;
+    var $content;
 
     /**