Changeset 59064

Timestamp:

09/18/2024 10:35:35 PM (3 weeks ago)

Author:

peterwilsoncc

Message:

Date/Time, PHP Compat: Prevent type errors using GMT offset option.

Prevents a potential type errors when making use of the gmt_offset option by casting the value to a float prior to performing calculations with the value.

This mainly accounts for incorrect storage of values, such as an empty string or city name.

Follow up to [58923].

Props chaion07, hellofromtonya, kirasong, mhshohel, mukesh27, nicolefurlan, nihar007, nurielmeni, oglekler, peterwilsoncc, prionkor, rajinsharwar, rarst, rleeson, sabernhardt, SergeyBiryukov, swissspidy, toastercookie, verygoode.
Fixes #56358, #58986, #60629.

Location:

trunk/src

Files:

• wp-admin/update-core.php (modified) (1 diff)
• wp-includes/bookmark-template.php (modified) (1 diff)
• wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• wp-mail.php (modified) (1 diff)

trunk/src/wp-admin/update-core.php

@@ -1097 +1097 @@
 
     if ( $current && isset( $current->last_checked ) ) {
-        $last_update_check = $current->last_checked + get_option( 'gmt_offset' ) * HOUR_IN_SECONDS;
+        $last_update_check = $current->last_checked + (int) ( (float) get_option( 'gmt_offset' ) * HOUR_IN_SECONDS );
     }
 

trunk/src/wp-includes/bookmark-template.php

@@ -91 +91 @@
                     gmdate(
                         get_option( 'links_updated_date_format' ),
-                        $bookmark->link_updated_f + ( get_option( 'gmt_offset' ) * HOUR_IN_SECONDS )
+                        $bookmark->link_updated_f + (int) ( (float) get_option( 'gmt_offset' ) * HOUR_IN_SECONDS )
                     )
                 );

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1817 +1817 @@
              */
             if ( '0000-00-00 00:00:00' === $post->post_modified_gmt ) {
-                $post_modified_gmt = gmdate( 'Y-m-d H:i:s', strtotime( $post->post_modified ) - ( get_option( 'gmt_offset' ) * HOUR_IN_SECONDS ) );
+                $post_modified_gmt = gmdate( 'Y-m-d H:i:s', strtotime( $post->post_modified ) - (int) ( (float) get_option( 'gmt_offset' ) * HOUR_IN_SECONDS ) );
             } else {
                 $post_modified_gmt = $post->post_modified_gmt;

trunk/src/wp-mail.php

@@ -45 +45 @@
 set_transient( 'mailserver_last_checked', true, WP_MAIL_INTERVAL );
 
-$time_difference = get_option( 'gmt_offset' ) * HOUR_IN_SECONDS;
+$time_difference = (int) ( (float) get_option( 'gmt_offset' ) * HOUR_IN_SECONDS );
 
 $phone_delim = '::';