Changeset 59077

Timestamp:

09/21/2024 02:39:52 PM (4 months ago)

Author:

SergeyBiryukov

Message:

Editor: Optimize is_callable() checks in traverse_and_serialize_blocks().

This aims to improve performance by reducing the number of function calls.

Follow-up to [56644].

Props welcher, Cybr, mukesh27, aristath.
Fixes #62063.

File:

• trunk/src/wp-includes/blocks.php (modified) (2 diffs)

trunk/src/wp-includes/blocks.php

@@ -1691 +1691 @@
     $parent_block = null; // At the top level, there is no parent block to pass to the callbacks; yet the callbacks expect a reference.
 
+    $pre_callback_is_callable  = is_callable( $pre_callback );
+    $post_callback_is_callable = is_callable( $post_callback );
+
     foreach ( $blocks as $index => $block ) {
-        if ( is_callable( $pre_callback ) ) {
+        if ( $pre_callback_is_callable ) {
             $prev = 0 === $index
                 ? null
@@ -1703 +1706 @@
         }
 
-        if ( is_callable( $post_callback ) ) {
+        if ( $post_callback_is_callable ) {
             $next = count( $blocks ) - 1 === $index
                 ? null