Changeset 59081 for trunk/tests/phpunit/tests/blocks/renderCommentTemplate.php

Timestamp:

09/23/2024 12:48:32 PM (23 months ago)

Author:

gziolo

Message:

Comments: Pass $page as argument to comments functions

Removes query alteration from build_comment_query_vars_from_block by introducing a new way to pass the $page as argument to functions handling pagination for the comments.

Props cybr, santosguillamot, bernhard-reiter, gziolo.
Fixes #60806.

File:

• trunk/tests/phpunit/tests/blocks/renderCommentTemplate.php (modified) (2 diffs)

trunk/tests/phpunit/tests/blocks/renderCommentTemplate.php

@@ -220 +220 @@
          * Test that both "Older Comments" and "Newer Comments" are displayed in the correct order
          * inside the Comment Query Loop when we enable pagination on Discussion Settings.
-         * In order to do that, it should exist a query var 'cpage' set with the $comment_args['paged'] value.
          *
          * @ticket 55505
+         * @ticket 60806
          * @covers ::build_comment_query_vars_from_block
          */
-        public function test_build_comment_query_vars_from_block_sets_cpage_var() {
+        public function test_build_comment_query_vars_from_block_sets_max_num_pages() {
 
                 // This could be any number, we set a fixed one instead of a random for better performance.
@@ -254 +254 @@
                 $actual = build_comment_query_vars_from_block( $block );
                 $this->assertSame( $comment_query_max_num_pages, $actual['paged'] );
-                $this->assertSame( $comment_query_max_num_pages, get_query_var( 'cpage' ) );
         }