Changeset 59084

Timestamp:

09/24/2024 04:38:36 PM (2 months ago)

Author:

TimothyBlynJacobs

Message:

App Passwords: Don't prevent non-unique App Password names.

In [50030] we enforced that Application Passwords have unique names. This was done with the assumption that applications would not connect to a user multiple times. However, in practice we've seen applications run into issues with the unique name constraint. Depending on the app, they may not know if they've been authorized before, or they may intentionally allow connecting multiple times. To prevent friction, App developers need to make their App Name unique, and in doing so often include things like the current date & time, which is already included in the App Passwords list table.

This commit removes this requirement to simplify usage of the Authorize Application flow.

Props mark-k, Boniu91, timothyblynjacobs, peterwilsoncc.
Fixes #54213.

Location:

trunk

Files:

• src/wp-includes/class-wp-application-passwords.php (modified) (1 diff)
• tests/e2e/specs/profile/applications-passwords.test.js (modified) (1 diff)
• tests/phpunit/tests/rest-api/application-passwords.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-application-passwords.php

@@ -93 +93 @@
         if ( empty( $args['name'] ) ) {
             return new WP_Error( 'application_password_empty_name', __( 'An application name is required to create an application password.' ), array( 'status' => 400 ) );
-        }
-
-        if ( self::application_name_exists_for_user( $user_id, $args['name'] ) ) {
-            return new WP_Error( 'application_password_duplicate_name', __( 'Each application name should be unique.' ), array( 'status' => 409 ) );
         }
 

trunk/tests/e2e/specs/profile/applications-passwords.test.js

@@ -40 +40 @@
         );
     } );
-
-    test('should not allow to create two applications passwords with the same name', async ( {
-        page,
-        applicationPasswords
-    } ) => {
-        await applicationPasswords.create();
-        await applicationPasswords.create();
-
-        const errorMessage = page.getByRole( 'alert' );
-
-        await expect( errorMessage ).toHaveClass( /notice-error/ );
-        await expect(
-            errorMessage
-        ).toContainText(
-            'Each application name should be unique.'
-        );
-    });
 
     test( 'should correctly revoke a single application password', async ( {

trunk/tests/phpunit/tests/rest-api/application-passwords.php

@@ -78 +78 @@
                 'args'     => array( 'name' => '<script>console.log("Hello")</script>' ),
             ),
-            'application_password_duplicate_name when name exists' => array(
-                'expected' => array(
-                    'error_code'    => 'application_password_duplicate_name',
-                    'error_message' => 'Each application name should be unique.',
-                ),
-                'args'     => array( 'name' => 'test2' ),
-                'names'    => array( 'test1', 'test2' ),
-            ),
         );
     }
@@ -197 +189 @@
         );
     }
+
+    /**
+     * @ticket 51941
+     */
+    public function test_can_create_duplicate_app_password_names() {
+        $created = WP_Application_Passwords::create_new_application_password( self::$user_id, array( 'name' => 'My App' ) );
+        $this->assertNotWPError( $created, 'First attempt to create an application password should not return an error' );
+        $created = WP_Application_Passwords::create_new_application_password( self::$user_id, array( 'name' => 'My App' ) );
+        $this->assertNotWPError( $created, 'Second attempt to create an application password should not return an error' );
+    }
 }