Changeset 59108

Timestamp:

09/27/2024 07:51:31 PM (9 months ago)

Author:

hellofromTonya

Message:

Code Modernization: Fix trigger_error() with E_USER_ERROR deprecation in WP_Test_Stream::open().

PHP 8.4 deprecates the use of trigger_errror() with E_USER_ERROR as the error level, as there are a number of gotchas to this way of creating a Fatal Error (finally blocks not executing, destructors not executing).
The recommended replacements are either to use exceptions or to do a hard exit.

As this is a test-only class, do not have to take BC-breaks into account.

Also, as this is a test helper, throwing a exception is the most appropriate solution.

Reference:

• ​https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_passing_e_user_error_to_trigger_error

Follow-up to [49230].

Props jrf.
See #62061.

File:

• trunk/tests/phpunit/includes/class-wp-test-stream.php (modified) (1 diff)

trunk/tests/phpunit/includes/class-wp-test-stream.php

@@ -58 +58 @@
 
         if ( empty( $this->bucket ) ) {
-            trigger_error( 'Cannot use an empty bucket name', E_USER_ERROR );
+            throw new Exception( 'Cannot use an empty bucket name' );
         }