Changeset 59120 for trunk/src/wp-includes/class-walker-nav-menu.php

Timestamp:

09/30/2024 05:17:54 AM (4 months ago)

Author:

peterwilsoncc

Message:

General: Remove noopener from links opening in a new tab.

Removes the automatic addition of rel="noopener noreferrer" from links targeting a new tab or window, target='_blank'. Since this was introduced, supported browsers have changed their security policies and no longer allow the opened link to have JavaScript access to the previous tab.

Deprecates:

• wp_targeted_link_rel()
• wp_targeted_link_rel_callback()
• wp_init_targeted_link_rel_filters(): converted to a noop function
• wp_remove_targeted_link_rel_filters(): converted to a noop function

The deprecated functions are retained in formatting.php as in SHORTINIT mode the file is included while deprecated.php is not.

This also removes the noopener from links hard coded within the WordPress dashboard linking to documentation and other resources.

Props audrasjb, azaozz, dhruval04, dorzki, neo2k23, presskopp, sabernhardt, swissspidy, tobiasbg.
Fixes #53843.

File:

• trunk/src/wp-includes/class-walker-nav-menu.php (modified) (1 diff)

trunk/src/wp-includes/class-walker-nav-menu.php

@@ -216 +216 @@
         $atts['title']  = ! empty( $menu_item->attr_title ) ? $menu_item->attr_title : '';
         $atts['target'] = ! empty( $menu_item->target ) ? $menu_item->target : '';
-        if ( '_blank' === $menu_item->target && empty( $menu_item->xfn ) ) {
-            $atts['rel'] = 'noopener';
-        } else {
-            $atts['rel'] = $menu_item->xfn;
-        }
+        $atts['rel']    = ! empty( $menu_item->xfn ) ? $menu_item->xfn : '';
 
         if ( ! empty( $menu_item->url ) ) {