Changeset 59122

Timestamp:

09/30/2024 06:47:20 AM (2 weeks ago)

Author:

cbravobernal

Message:

Block bindings: Add canUpdateBlockBindings editor setting.

Adds a canUpdateBlockBindings editor setting that allows to decide if the user is able to create and modify bindings through the UI. By default, only admin users can do it, but it can be overridden with block_editor_settings_all filter.

Props santosguillamot, gziolo, jorbin, noisysocks, matveb, cbravobernal, youknowriad, mamaduka, timothyblynjacobs, peterwilsoncc, drivingralle.
Fixes #61945.

Location:

trunk

Files:

• src/wp-includes/block-editor.php (modified) (1 diff)
• src/wp-includes/capabilities.php (modified) (1 diff)
• tests/phpunit/tests/user/capabilities.php (modified) (2 diffs)

trunk/src/wp-includes/block-editor.php

@@ -665 +665 @@
         }
     }
+
+    $editor_settings['canUpdateBlockBindings'] = current_user_can( 'edit_block_binding', $block_editor_context );
 
     /**

trunk/src/wp-includes/capabilities.php

@@ -802 +802 @@
             $caps = map_meta_cap( 'edit_user', $user_id, $args[0] );
             break;
+        case 'edit_block_binding':
+            $block_editor_context = $args[0];
+            if ( isset( $block_editor_context->post ) ) {
+                $object_id = $block_editor_context->post->ID;
+            }
+            /*
+             * If the post ID is null, check if the context is the site editor.
+             * Fall back to the edit_theme_options in that case.
+             */
+            if ( ! isset( $object_id ) ) {
+                if ( ! isset( $block_editor_context->name ) || 'core/edit-site' !== $block_editor_context->name ) {
+                    $caps[] = 'do_not_allow';
+                    break;
+                }
+                $caps = map_meta_cap( 'edit_theme_options', $user_id );
+                break;
+            }
+
+            $object_subtype = get_object_subtype( 'post', (int) $object_id );
+            if ( empty( $object_subtype ) ) {
+                $caps[] = 'do_not_allow';
+                break;
+            }
+
+            $caps = map_meta_cap( "edit_{$object_subtype}", $user_id, $object_id );
+            break;
         default:
             // Handle meta capabilities for custom post types.

trunk/tests/phpunit/tests/user/capabilities.php

@@ -571 +571 @@
             $expected['edit_app_password'],
             $expected['delete_app_passwords'],
-            $expected['delete_app_password']
+            $expected['delete_app_password'],
+            $expected['edit_block_binding']
         );
 
@@ -2377 +2378 @@
         return $data;
     }
+
+    /**
+     * Test `edit_block_binding` meta capability is properly mapped.
+     *
+     * @ticket 61945
+     */
+    public function test_edit_block_binding_caps_are_mapped_correctly() {
+        $author = self::$users['administrator'];
+        $post   = self::factory()->post->create_and_get(
+            array(
+                'post_author' => $author->ID,
+                'post_type'   => 'post',
+            )
+        );
+
+        foreach ( self::$users as $role => $user ) {
+            // It should map to `edit_{post_type}` if editing a post.
+            $this->assertSame(
+                user_can( $user->ID, 'edit_post', $post->ID ),
+                user_can(
+                    $user->ID,
+                    'edit_block_binding',
+                    new WP_Block_Editor_Context(
+                        array(
+                            'post' => $post,
+                            'name' => 'core/edit-post',
+                        )
+                    )
+                ),
+                "Role: {$role} in post editing"
+            );
+            // It should map to `edit_theme_options` if editing a template.
+            $this->assertSame(
+                user_can( $user->ID, 'edit_theme_options' ),
+                user_can(
+                    $user->ID,
+                    'edit_block_binding',
+                    new WP_Block_Editor_Context(
+                        array(
+                            'post' => null,
+                            'name' => 'core/edit-site',
+                        )
+                    )
+                ),
+                "Role: {$role} in template editing"
+            );
+        }
+    }
 }