Changeset 59134

Timestamp:

09/30/2024 06:22:36 PM (23 months ago)

Author:

joedolson

Message:

Quick/Bulk Edit: Add notice if no items selected.

Add an error notice if a user attempts to apply bulk edits with no items selected. Applies to post lists, comments, taxonomies, and plugins screens.

Props garrett-eclipse, nrqsnchz, sumitsingh, nihar007, royho, sabernhardt, oglekler, quadthemes, ankit-k-gupta, fnpen, ukdrahul, joedolson.
Fixes #45006, #58479.

Location:

trunk/src

Files:

• js/_enqueues/admin/common.js (modified) (2 diffs)
• js/_enqueues/admin/inline-edit-post.js (modified) (1 diff)
• js/_enqueues/wp/updates.js (modified) (1 diff)
• wp-admin/includes/class-wp-list-table.php (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/common.js

@@ -1115 +1115 @@
         }
 
-        $document.on( 'wp-updates-notice-added wp-plugin-install-error wp-plugin-update-error wp-plugin-delete-error wp-theme-install-error wp-theme-delete-error', makeNoticesDismissible );
+        $document.on( 'wp-updates-notice-added wp-plugin-install-error wp-plugin-update-error wp-plugin-delete-error wp-theme-install-error wp-theme-delete-error wp-notice-added', makeNoticesDismissible );
 
         // Init screen meta.
@@ -1276 +1276 @@
         // Marry the secondary "Change role to" controls to the primary controls:
         marryControls( $('#new_role'), $('#changeit'), $('#new_role2'), $('#changeit2') );
+
+        var addAdminNotice = function( data ) {
+                var $notice = $( data.selector ),
+                        $headerEnd = $( '.wp-header-end' ),
+                        type,
+                        dismissible,
+                        $adminNotice;
+
+                delete data.selector;
+
+                dismissible = ( data.dismissible && data.dismissible === true ) ? ' is-dismissible' : '';
+                type        = ( data.type ) ? data.type : 'info';
+
+                $adminNotice = '<div id="' + data.id + '" class="notice notice-' + data.type + dismissible + '"><p>' + data.message + '</p></div>';
+
+                // Check if this admin notice already exists.
+                if ( ! $notice.length ) {
+                        $notice = $( '#' + data.id );
+                }
+
+                if ( $notice.length ) {
+                        $notice.replaceWith( $adminNotice );
+                } else if ( $headerEnd.length ) {
+                        $headerEnd.after( $adminNotice );
+                } else {
+                        if ( 'customize' === pagenow ) {
+                                $( '.customize-themes-notifications' ).append( $adminNotice );
+                        } else {
+                                $( '.wrap' ).find( '> h1' ).after( $adminNotice );
+                        }
+                }
+
+                $document.trigger( 'wp-notice-added' );
+        };
+
+        $( '.bulkactions' ).parents( 'form' ).on( 'submit', function( event ) {
+                var form = this,
+                        submitterName = event.originalEvent && event.originalEvent.submitter ? event.originalEvent.submitter.name : false;
+
+                // Observe submissions from posts lists for 'bulk_action' or users lists for 'new_role'.
+                var bulkFieldRelations = {
+                        'bulk_action' : 'action',
+                        'changeit' : 'new_role'
+                };
+                if ( ! Object.keys( bulkFieldRelations ).includes( submitterName ) ) {
+                        return;
+                }
+
+                var values = new FormData(form);
+                var value = values.get( bulkFieldRelations[ submitterName ] ) || '-1';
+
+                // Check that the action is not the default one.
+                if ( value !== '-1' ) {
+                        // Check that at least one item is selected.
+                        var itemsSelected = form.querySelectorAll( '.wp-list-table tbody .check-column input[type="checkbox"]:checked' );
+
+                        if ( itemsSelected.length > 0 ) {
+                                return;
+                        }
+                }
+                event.preventDefault();
+                event.stopPropagation();
+                $( 'html, body' ).animate( { scrollTop: 0 } );
+
+                var errorMessage = __( 'Please select at least one item to perform this action on.' );
+                addAdminNotice( {
+                        id: 'no-items-selected',
+                        type: 'error',
+                        message: errorMessage,
+                        dismissible: true,
+                } );
+
+                wp.a11y.speak( errorMessage );
+        });
 
         /**

trunk/src/js/_enqueues/admin/inline-edit-post.js

@@ -149 +149 @@
                  */
                 $('#doaction').on( 'click', function(e){
-                        var n;
+                        var n,
+                                $itemsSelected = $( '#posts-filter .check-column input[type="checkbox"]:checked' );
+
+                        if ( $itemsSelected.length < 1 ) {
+                                return;
+                        }
 
                         t.whichBulkButtonId = $( this ).attr( 'id' );

trunk/src/js/_enqueues/wp/updates.js

@@ -2833 +2833 @@
                         // Bail if there were no items selected.
                         if ( ! itemsSelected.length ) {
-                                event.preventDefault();
-                                $( 'html, body' ).animate( { scrollTop: 0 } );
-
-                                return wp.updates.addAdminNotice( {
-                                        id:        'no-items-selected',
-                                        className: 'notice-error is-dismissible',
-                                        message:   __( 'Please select at least one item to perform this action on.' )
-                                } );
+                                bulkAction = false;
                         }
 

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -626 +626 @@
                 echo "</select>\n";
 
-                submit_button( __( 'Apply' ), 'action', '', false, array( 'id' => "doaction$two" ) );
+                submit_button( __( 'Apply' ), 'action', 'bulk_action', false, array( 'id' => "doaction$two" ) );
                 echo "\n";
         }

trunk/src/wp-includes/script-loader.php

@@ -755 +755 @@
         );
 
-        $scripts->add( 'common', "/wp-admin/js/common$suffix.js", array( 'jquery', 'hoverIntent', 'utils' ), false, 1 );
+        $scripts->add( 'common', "/wp-admin/js/common$suffix.js", array( 'jquery', 'hoverIntent', 'utils', 'wp-a11y' ), false, 1 );
         $scripts->set_translations( 'common' );