Changeset 59157 for trunk/tests/phpunit/tests/l10n/loadTextdomain.php

Timestamp:

10/02/2024 01:42:11 PM (2 months ago)

Author:

swissspidy

Message:

I18N: Do not load translations directly in load_*_textdomain.

In [59127], _doing_it_wrong warnings were added if plugins or themes load translations too early, either through a manual function call or just-in-time loading.

Because many plugins and themes still manually call load_plugin_textdomain(), load_theme_textdomain() or load_muplugin_textdomain(), even though they don't have to anymore, that caused a lot of warnings.

With this new approach, these functions merely register the translations path in the existing WP_Textdomain_Registry and do not immediately try to load the translations anymore. The loading is all handled by the just-in-time functionality.

This way, warnings will only be emitted if triggering the just-in-time loading too early, greatly improving the developer experience and to a degree also performance.

Props swissspidy, sergeybiryukov, mukesh27.
See #44937.

File:

• trunk/tests/phpunit/tests/l10n/loadTextdomain.php (modified) (4 diffs)

trunk/tests/phpunit/tests/l10n/loadTextdomain.php

@@ -6 +6 @@
  */
 class Tests_L10n_LoadTextdomain extends WP_UnitTestCase {
-    protected $locale;
     protected static $user_id;
 
@@ -21 +20 @@
         parent::set_up();
 
-        $this->locale = '';
-
-        add_filter( 'plugin_locale', array( $this, 'store_locale' ) );
-        add_filter( 'theme_locale', array( $this, 'store_locale' ) );
-
         /** @var WP_Textdomain_Registry $wp_textdomain_registry */
         global $wp_textdomain_registry;
@@ -40 +34 @@
 
         parent::tear_down();
-    }
-
-    public function store_locale( $locale ) {
-        $this->locale = $locale;
-
-        return $locale;
     }
 
@@ -234 +222 @@
 
     /**
-     * @covers ::load_muplugin_textdomain
-     */
-    public function test_load_muplugin_textdomain_site_locale() {
-        load_muplugin_textdomain( 'wp-tests-domain' );
-
-        $this->assertSame( get_locale(), $this->locale );
-    }
-
-    /**
-     * @ticket 38485
-     *
-     * @covers ::load_muplugin_textdomain
-     */
-    public function test_load_muplugin_textdomain_user_locale() {
-        set_current_screen( 'dashboard' );
-        wp_set_current_user( self::$user_id );
-
-        load_muplugin_textdomain( 'wp-tests-domain' );
-
-        $this->assertSame( get_user_locale(), $this->locale );
-    }
-
-    /**
-     * @covers ::load_plugin_textdomain
-     */
-    public function test_load_plugin_textdomain_site_locale() {
-        load_plugin_textdomain( 'wp-tests-domain' );
-
-        $this->assertSame( get_locale(), $this->locale );
-    }
-
-    /**
-     * @ticket 38485
-     *
-     * @covers ::load_plugin_textdomain
-     */
-    public function test_load_plugin_textdomain_user_locale() {
-        set_current_screen( 'dashboard' );
-        wp_set_current_user( self::$user_id );
-
-        load_plugin_textdomain( 'wp-tests-domain' );
-
-        $this->assertSame( get_user_locale(), $this->locale );
-    }
-
-    /**
-     * @covers ::load_theme_textdomain
-     */
-    public function test_load_theme_textdomain_site_locale() {
-        load_theme_textdomain( 'wp-tests-domain' );
-
-        $this->assertSame( get_locale(), $this->locale );
-    }
-
-    /**
-     * @ticket 38485
-     *
-     * @covers ::load_theme_textdomain
-     */
-    public function test_load_theme_textdomain_user_locale() {
-        set_current_screen( 'dashboard' );
-        wp_set_current_user( self::$user_id );
-
-        load_theme_textdomain( 'wp-tests-domain' );
-
-        $this->assertSame( get_user_locale(), $this->locale );
-    }
-
-    /**
      * @ticket 58035
      *