Changeset 59159 for trunk/src/wp-admin/includes/class-theme-upgrader.php

Timestamp:

10/03/2024 12:23:53 AM (19 months ago)

Author:

peterwilsoncc

Message:

General: Expand use of wp_get_wp_version().

Expands the use of wp_get_wp_version() to get an unmodified value of the current WordPress version in various locations in which it would be unhelpful if a plugin has modified the global $wp_version.

This includes:

• Theme and plugin compatibility tests
• During the upgrade process of WP Core
• Debug and site health data reports of the current version
• Version number display in the dashboard
• Block theme export and caching utilities
• The WPDB class

Props peterwilsoncc, hellofromtonya.
See #61627.

File:

• trunk/src/wp-admin/includes/class-theme-upgrader.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-theme-upgrader.php

@@ -372 +372 @@
      * @since 3.7.0 The `$args` parameter was added, making clearing the update cache optional.
      *
-     * @global string $wp_version The WordPress version string.
-     *
      * @param string[] $themes Array of the theme slugs.
      * @param array    $args {
@@ -384 +382 @@
      */
     public function bulk_upgrade( $themes, $args = array() ) {
-        global $wp_version;
-
+        $wp_version  = wp_get_wp_version();
         $defaults    = array(
             'clear_update_cache' => true,
@@ -559 +556 @@
      *
      * @global WP_Filesystem_Base $wp_filesystem WordPress filesystem subclass.
-     * @global string             $wp_version    The WordPress version string.
      *
      * @param string $source The path to the downloaded package source.
@@ -565 +561 @@
      */
     public function check_package( $source ) {
-        global $wp_filesystem, $wp_version;
-
+        global $wp_filesystem;
+
+        $wp_version           = wp_get_wp_version();
         $this->new_theme_data = array();