Changeset 59163

Timestamp:

10/03/2024 11:42:43 PM (2 months ago)

Author:

SergeyBiryukov

Message:

Tests: Bring some consistency to links_add_base_url() and links_add_target() tests.

Includes:

• Correcting the test class name as per the naming conventions.
• Documenting data provider values using hash notation.
• Passing the $attrs parameter to the function if not null.

Follow-up to [26328], [55563], [59162].

See #61530.

Location:

trunk/tests/phpunit/tests/formatting

Files:

• linksAddBaseUrl.php (modified) (6 diffs)
• linksAddTarget.php (modified) (3 diffs)

trunk/tests/phpunit/tests/formatting/linksAddBaseUrl.php

@@ -2 +2 @@
 
 /**
- * Tests for the links_add_base_url function.
+ * Tests for the links_add_base_url() function.
  *
  * @group formatting
@@ -8 +8 @@
  * @covers ::links_add_base_url
  */
-class Tests_formatting_linksAddBaseUrl extends WP_UnitTestCase {
+class Tests_Formatting_LinksAddBaseUrl extends WP_UnitTestCase {
 
     /**
@@ -16 +16 @@
      */
     public function test_links_add_base_url( $content, $base, $attrs, $expected ) {
-        if ( $attrs ) {
+        if ( is_null( $attrs ) ) {
+            $this->assertSame( $expected, links_add_base_url( $content, $base ) );
+        } else {
             $this->assertSame( $expected, links_add_base_url( $content, $base, $attrs ) );
-        } else {
-            $this->assertSame( $expected, links_add_base_url( $content, $base ) );
         }
     }
 
     /**
-     * Data provider for test_links_add_base_url().
+     * Data provider.
      *
-     * @return array[]
+     * @return array {
+     *     @type array {
+     *         @type string     $content  String to search for links in.
+     *         @type string     $base     The base URL to prefix to links.
+     *         @type array|null $attrs    The attributes which should be processed.
+     *         @type string     $expected Expected output.
+     *     }
+     * }
      */
     public function data_links_add_base_url() {
@@ -42 +49 @@
                 'expected' => '<a href="http://localhost/url" />',
             ),
-            'relative_scheme' => array(
+            'relative scheme' => array(
                 'content'  => '<a href="//localhost/url" />',
                 'base'     => 'http://localhost',
@@ -48 +55 @@
                 'expected' => '<a href="http://localhost/url" />',
             ),
-            'empty_array'     => array(
+            'empty array'     => array(
                 'content'  => '<a href="url" target="_blank" />',
                 'base'     => 'https://localhost',
                 'attrs'    => array(),
-                'expected' => '<a href="https://localhost/url" target="_blank" />',
+                'expected' => '<a href="https://localhost/url" target="https://localhost/_blank" />',
             ),
-            'data_url'        => array(
+            'data-url'        => array(
                 'content'  => '<a href="url" data-url="url" />',
                 'base'     => 'https://localhost',
@@ -66 +73 @@
                 'expected' => '<a href="https://localhost/url" />',
             ),
-            'no_href'         => array(
+            'no href'         => array(
                 'content'  => '<a data-url="/url" />',
                 'base'     => 'https://localhost',

trunk/tests/phpunit/tests/formatting/linksAddTarget.php

@@ -1 +1 @@
 <?php
 /**
+ * Tests for the links_add_target() function.
+ *
  * @group formatting
  *
@@ -8 +10 @@
 
     /**
-     * Tests the links_add_target() function.
+     * @ticket 26164
      *
      * @dataProvider data_links_add_target
@@ -27 +29 @@
      * @return array {
      *     @type array {
-     *         @type string $content  String to search for links in.
-     *         @type string $target   The target to add to the links.
-     *         @type string $tags     An array of tags to apply to.
-     *         @type string $expected Expected output.
+     *         @type string     $content  String to search for links in.
+     *         @type string     $target   The target to add to the links.
+     *         @type array|null $tags     An array of tags to apply to.
+     *         @type string     $expected Expected output.
      *     }
      * }