Changeset 59168

Timestamp:

10/04/2024 02:07:03 PM (9 months ago)

Author:

desrosj

Message:

Build/Test Tools: Enable testing for PHP 8.4.

With PHP 8.4 due out in November later this year, contributors have been working on ensuring WordPress 6.7 is as compatible as possible. Enough progress has been made during this release cycle where PHPUnit tests now run successfully with no failures reported.

This change enables PHP 8.4 testing throughout Core’s GitHub Action workflows to ensure no new problems are introduced going forward.

There are two exceptions to this:

• The Importer plugin has some compatibility issues that produce test failures. There is an open pull request upstream, but these problematic tests have been marked skipped when running on PHP 8.4 until that PR is merged.
• Since no stable versions of xDebug with PHP 8.4 support have been published, these tests are also skipped for now.

Props jrf, desrosj.
See #62061.

Location:

trunk

Files:

• .github/workflows/phpunit-tests.yml (modified) (2 diffs)
• .github/workflows/reusable-phpunit-tests-v3.yml (modified) (1 diff)
• .github/workflows/upgrade-testing.yml (modified) (3 diffs)
• .version-support-php.json (modified) (1 diff)
• tests/phpunit/tests/import/parser.php (modified) (5 diffs)

trunk/.github/workflows/phpunit-tests.yml

@@ -46 +46 @@
       matrix:
         os: [ ubuntu-latest ]
-        php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
+        php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
         db-type: [ 'mysql' ]
         db-version: [ '5.7', '8.0', '8.1', '8.2', '8.3' ]
@@ -117 +117 @@
       matrix:
         os: [ ubuntu-latest ]
-        php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
+        php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
         db-type: [ 'mariadb' ]
         db-version: [ '10.4', '10.6', '10.11', '11.2' ]

trunk/.github/workflows/reusable-phpunit-tests-v3.yml

@@ -183 +183 @@
       # __fakegroup__ is excluded to force PHPUnit to ignore the <exclude> settings in phpunit.xml.dist.
       - name: Run (Xdebug) tests
-        if: ${{ inputs.php != '8.3' }}
+        if: ${{ inputs.php != '8.4' }}
         continue-on-error: ${{ inputs.allow-errors }}
         run: LOCAL_PHP_XDEBUG=true node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit -v --group xdebug --exclude-group __fakegroup__

trunk/.github/workflows/upgrade-testing.yml

@@ -44 +44 @@
       matrix:
         os: [ 'ubuntu-latest' ]
-        php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
+        php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
         db-type: [ 'mysql' ]
         db-version: [ '5.7', '8.0' ]
@@ -94 +94 @@
       matrix:
         os: [ 'ubuntu-latest' ]
-        php: [ '8.0', '8.1', '8.2', '8.3' ]
+        php: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
         db-type: [ 'mysql' ]
         db-version: [ '5.7', '8.0' ]
@@ -144 +144 @@
       matrix:
         os: [ 'ubuntu-latest' ]
-        php: [ '8.0', '8.1', '8.2', '8.3' ]
+        php: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
         db-type: [ 'mysql' ]
         db-version: [ '5.7', '8.0' ]

trunk/.version-support-php.json

@@ -7 +7 @@
         "8.1",
         "8.2",
-        "8.3"
+        "8.3",
+        "8.4"
     ],
     "6-6": [

trunk/tests/phpunit/tests/import/parser.php

@@ -26 +26 @@
      */
     public function test_malformed_wxr() {
+        if ( PHP_VERSION_ID >= 80400 ) {
+            $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+        }
+
         $file = DIR_TESTDATA . '/export/malformed.xml';
 
@@ -43 +47 @@
      */
     public function test_invalid_wxr() {
+        if ( PHP_VERSION_ID >= 80400 ) {
+            $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+        }
+
         $f1 = DIR_TESTDATA . '/export/missing-version-tag.xml';
         $f2 = DIR_TESTDATA . '/export/invalid-version-tag.xml';
@@ -62 +70 @@
      */
     public function test_wxr_version_1_1() {
+        if ( PHP_VERSION_ID >= 80400 ) {
+            $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+        }
+
         $file = DIR_TESTDATA . '/export/valid-wxr-1.1.xml';
 
@@ -160 +172 @@
      */
     public function test_wxr_version_1_0() {
+        if ( PHP_VERSION_ID >= 80400 ) {
+            $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+        }
+
         $file = DIR_TESTDATA . '/export/valid-wxr-1.0.xml';
 
@@ -258 +274 @@
      */
     public function test_escaped_cdata_closing_sequence() {
+        if ( PHP_VERSION_ID >= 80400 ) {
+            $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+        }
+
         $file = DIR_TESTDATA . '/export/crazy-cdata-escaped.xml';