Changeset 59170 for trunk/.github/workflows/performance.yml

Timestamp:

10/04/2024 04:24:33 PM (15 months ago)

Author:

flixos90

Message:

Build/Test Tools: Resolve access failure to continue sending commit performance data to Code Vitals dashboard.

This originally broke in [58165] and unfortunately went unnoticed for a while because the failing request to send the data did not cause the GitHub workflows to fail. This changeset resolves the underlying access problem, which was happening because reusable GitHub workflows do not automatically receive secrets from the calling workflow. More concretely, the relevant CODEVITALS_PROJECT_TOKEN was not being explicitly passed to the reusable workflow.

The changeset also includes a change so that in the future a failing request would cause the workflow to fail, which ensures a similar problem further down the road wouldn't go unnoticed.

Props joemcgill, flixos90, swissspidy, mukesh27, sergeybiryukov
Fixes #62153.
See #61213.

File:

• trunk/.github/workflows/performance.yml (modified) (1 diff)

trunk/.github/workflows/performance.yml

@@ -44 +44 @@
     with:
       memcached: ${{ matrix.memcached }}
+    secrets:
+      CODEVITALS_PROJECT_TOKEN: ${{ secrets.CODEVITALS_PROJECT_TOKEN }}
 
   slack-notifications: