Changeset 59183

Timestamp:

10/06/2024 04:54:10 PM (16 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp_list_comments().

Follow-up to [8962], [9296], [9424], [34735], [36157].

Props deepakrohilla, sabernhardt, aristath, poena, afercia, SergeyBiryukov.
Fixes #62169. See #61607.

File:

• trunk/src/wp-includes/comment-template.php (modified) (6 diffs)

trunk/src/wp-includes/comment-template.php

@@ -565 +565 @@
 
     // Alt for top-level comments.
-    if ( 1 == $comment_depth ) {
+    if ( 1 === $comment_depth ) {
         if ( $comment_thread_alt % 2 ) {
             $classes[] = 'thread-odd';
@@ -815 +815 @@
         $cpage = $args['page'];
 
-        if ( '' == $cpage ) {
+        if ( '' === $cpage ) {
             if ( ! empty( $in_comment_loop ) ) {
-                $cpage = get_query_var( 'cpage' );
+                $cpage = (int) get_query_var( 'cpage' );
             } else {
                 // Requires a database hit, so we only do it when we can't figure out from context.
@@ -1606 +1606 @@
     $overridden_cpage = false;
 
-    if ( '' == get_query_var( 'cpage' ) && $wp_query->max_num_comment_pages > 1 ) {
+    if ( '' === get_query_var( 'cpage' ) && $wp_query->max_num_comment_pages > 1 ) {
         set_query_var( 'cpage', 'newest' === get_option( 'default_comments_page' ) ? get_comment_pages_count() : 1 );
         $overridden_cpage = true;
@@ -2292 +2292 @@
          */
         if ( $parsed_args['page'] || $parsed_args['per_page'] ) {
-            $current_cpage = get_query_var( 'cpage' );
+            $current_cpage = (int) get_query_var( 'cpage' );
             if ( ! $current_cpage ) {
                 $current_cpage = 'newest' === get_option( 'default_comments_page' ) ? 1 : $wp_query->max_num_comment_pages;
             }
 
-            $current_per_page = get_query_var( 'comments_per_page' );
-            if ( $parsed_args['page'] != $current_cpage || $parsed_args['per_page'] != $current_per_page ) {
+            $current_per_page = (int) get_query_var( 'comments_per_page' );
+            if ( (int) $parsed_args['page'] !== $current_cpage || (int) $parsed_args['per_page'] !== $current_per_page ) {
                 $comment_args = array(
                     'post_id' => get_the_ID(),
@@ -2349 +2349 @@
             if ( $wp_query->max_num_comment_pages ) {
                 $default_comments_page = get_option( 'default_comments_page' );
-                $cpage                 = get_query_var( 'cpage' );
+                $cpage                 = (int) get_query_var( 'cpage' );
+
                 if ( 'newest' === $default_comments_page ) {
                     $parsed_args['cpage'] = $cpage;
-
+                } elseif ( 1 === $cpage ) {
                     /*
-                    * When first page shows oldest comments, post permalink is the same as
-                    * the comment permalink.
-                    */
-                } elseif ( 1 == $cpage ) {
+                     * When the first page shows the oldest comments,
+                     * post permalink is the same as the comment permalink.
+                     */
                     $parsed_args['cpage'] = '';
                 } else {
@@ -2390 +2390 @@
             $parsed_args['page'] = get_query_var( 'cpage' );
         } else {
-            $threaded            = ( -1 != $parsed_args['max_depth'] );
+            $threaded            = ( -1 !== (int) $parsed_args['max_depth'] );
             $parsed_args['page'] = ( 'newest' === get_option( 'default_comments_page' ) ) ? get_comment_pages_count( $_comments, $parsed_args['per_page'], $threaded ) : 1;
             set_query_var( 'cpage', $parsed_args['page'] );
         }
     }
+
     // Validation check.
-    $parsed_args['page'] = (int) $parsed_args['page'];
-    if ( 0 == $parsed_args['page'] && 0 != $parsed_args['per_page'] ) {
+    $parsed_args['page']     = (int) $parsed_args['page'];
+    $parsed_args['per_page'] = (int) $parsed_args['per_page'];
+    if ( 0 === $parsed_args['page'] && 0 !== $parsed_args['per_page'] ) {
         $parsed_args['page'] = 1;
     }