Changeset 59189

Timestamp:

10/07/2024 05:11:43 PM (2 months ago)

Author:

joemcgill

Message:

Media: Cache the results of _wp_image_editor_choose.

This saves the WP_Image_Editor implementation that supports the queried options to a cache to avoid performing redundant compatibility checks, which can be expensive. For example, WP_Image_Editor_Imagick::supports_mime_type() can get called in the editor multiple times to determine which image formats can be supported during wp_plupload_default_settings().

With this cache, the support will be stored for 1 day, speeding up loading times for the editor. This also introduces a new global caching group, image_editor to manage any subsequent caches that are related to image editor optimizations.

Props joemcgill, desrosj, westonruter, flixos90, adamsilverstein, mukesh27, joehoyle.
Fixes #61532.

Location:

trunk/src/wp-includes

Files:

• load.php (modified) (1 diff)
• media.php (modified) (2 diffs)
• ms-blogs.php (modified) (2 diffs)

trunk/src/wp-includes/load.php

@@ -877 +877 @@
                 'blog_meta',
                 'global-posts',
+                'image_editor',
                 'networks',
                 'network-queries',

trunk/src/wp-includes/media.php

@@ -4192 +4192 @@
      */
     $implementations = apply_filters( 'wp_image_editors', array( 'WP_Image_Editor_Imagick', 'WP_Image_Editor_GD' ) );
-    $supports_input  = false;
+
+    $editors = wp_cache_get( 'wp_image_editor_choose', 'image_editor' );
+
+    if ( ! is_array( $editors ) ) {
+        $editors = array();
+    }
+
+    // Cache the chosen editor implementation based on specific args and available implementations.
+    $cache_key = md5( serialize( array( $args, $implementations ) ) );
+
+    if ( isset( $editors[ $cache_key ] ) ) {
+        return $editors[ $cache_key ];
+    }
+
+    // Assume no support until a capable implementation is identified.
+    $editor = false;
 
     foreach ( $implementations as $implementation ) {
@@ -4226 +4241 @@
              * Keep looking to see if we can find an implementation that supports both.
              */
-            $supports_input = $implementation;
+            $editor = $implementation;
             continue;
         }
 
         // Favor the implementation that supports both input and output mime types.
-        return $implementation;
-    }
-
-    return $supports_input;
+        $editor = $implementation;
+        break;
+    }
+
+    $editors[ $cache_key ] = $editor;
+
+    wp_cache_set( 'wp_image_editor_choose', $editors, 'image_editor', DAY_IN_SECONDS );
+
+    return $editor;
 }
 

trunk/src/wp-includes/ms-blogs.php

@@ -555 +555 @@
                         'blog_meta',
                         'global-posts',
+                        'image_editor',
                         'networks',
                         'network-queries',
@@ -649 +650 @@
                         'blog_meta',
                         'global-posts',
+                        'image_editor',
                         'networks',
                         'network-queries',