Changeset 59199

Timestamp:

10/09/2024 01:26:13 AM (5 months ago)

Author:

andrewserong

Message:

Editor: Fix writingMode support in dynamic blocks.

Adds missing handling for the typography.writingMode property to the style engine, so that dynamic blocks correctly render text orientation styles on the site frontend.

Props wildworks, aaronrobertshaw, poena, get_dave, ndiego.
Fixes #62189.
See #59306.

Location:

trunk

Files:

• src/wp-includes/style-engine/class-wp-style-engine.php (modified) (2 diffs)
• tests/phpunit/tests/style-engine/styleEngine.php (modified) (3 diffs)

trunk/src/wp-includes/style-engine/class-wp-style-engine.php

@@ -26 +26 @@
  * @since 6.5.0 Added support for background.backgroundPosition,
  *              background.backgroundRepeat and dimensions.aspectRatio.
+ * @since 6.7.0 Added support for typography.writingMode.
  */
 #[AllowDynamicProperties]
@@ -305 +306 @@
                 ),
                 'path'          => array( 'typography', 'letterSpacing' ),
+            ),
+            'writingMode'    => array(
+                'property_keys' => array(
+                    'default' => 'writing-mode',
+                ),
+                'path'          => array( 'typography', 'writingMode' ),
             ),
         ),

trunk/tests/phpunit/tests/style-engine/styleEngine.php

@@ -30 +30 @@
      * @ticket 60175
      * @ticket 61720
+     * @ticket 62189
      *
      * @covers ::wp_style_engine_get_styles
@@ -229 +230 @@
                         'textTransform'  => 'uppercase',
                         'letterSpacing'  => '2',
-                    ),
-                ),
-                'options'         => null,
-                'expected_output' => array(
-                    'css'          => 'font-size:clamp(2em, 2vw, 4em);font-family:Roboto,Oxygen-Sans,Ubuntu,sans-serif;font-style:italic;font-weight:800;line-height:1.3;column-count:2;text-decoration:underline;text-transform:uppercase;letter-spacing:2;',
+                        'writingMode'    => 'vertical-rl',
+                    ),
+                ),
+                'options'         => null,
+                'expected_output' => array(
+                    'css'          => 'font-size:clamp(2em, 2vw, 4em);font-family:Roboto,Oxygen-Sans,Ubuntu,sans-serif;font-style:italic;font-weight:800;line-height:1.3;column-count:2;text-decoration:underline;text-transform:uppercase;letter-spacing:2;writing-mode:vertical-rl;',
                     'declarations' => array(
                         'font-size'       => 'clamp(2em, 2vw, 4em)',
@@ -244 +246 @@
                         'text-transform'  => 'uppercase',
                         'letter-spacing'  => '2',
+                        'writing-mode'    => 'vertical-rl',
                     ),
                 ),