Changeset 59213 for trunk/tests/phpunit/tests/theme/wpThemeJson.php

Timestamp:

10/10/2024 09:05:04 PM (7 months ago)

Author:

flixos90

Message:

Themes: Improve performance of applying background image styles in theme.json.

The cost of using WP_Theme_JSON::get_block_nodes() for this in its original shape was high enough to lead to a performance regression. Therefore this changeset introduces a new option on the method that allows to bypass all logic except for retrieving the node paths, which is much faster and everything that this functionality needs.

Follow up to [58936].

Props mukesh27, flixos90, ramonopoly, joemcgill, andrewserong, swissspidy.
Fixes #61858.

File:

• trunk/tests/phpunit/tests/theme/wpThemeJson.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme/wpThemeJson.php

@@ -2442 +2442 @@
 
         $this->assertEqualSetsWithIndex( $expected, $actual );
+    }
+
+    /**
+     * This test covers `get_block_nodes` with the `$include_node_paths_only` option.
+     * When `true`, `$include_node_paths_only` should return only the paths of the block nodes.
+     *
+     * @ticket 61858
+     */
+    public function test_return_block_node_paths() {
+        $theme_json = new ReflectionClass( 'WP_Theme_JSON' );
+
+        $func = $theme_json->getMethod( 'get_block_nodes' );
+        $func->setAccessible( true );
+
+        $theme_json = array(
+            'version' => WP_Theme_JSON::LATEST_SCHEMA,
+            'styles'  => array(
+                'typography' => array(
+                    'fontSize' => '16px',
+                ),
+                'blocks'     => array(
+                    'core/button' => array(
+                        'color' => array(
+                            'background' => 'red',
+                        ),
+                    ),
+                    'core/group'  => array(
+                        'elements' => array(
+                            'link' => array(
+                                'color' => array(
+                                    'background' => 'blue',
+                                ),
+                            ),
+                        ),
+                    ),
+                ),
+            ),
+        );
+
+        $block_nodes = $func->invoke( null, $theme_json, array(), array( 'include_node_paths_only' => true ) );
+
+        $expected = array(
+            array(
+                'path' => array( 'styles', 'blocks', 'core/button' ),
+            ),
+            array(
+                'path' => array( 'styles', 'blocks', 'core/group' ),
+            ),
+            array(
+                'path' => array( 'styles', 'blocks', 'core/group', 'elements', 'link' ),
+            ),
+        );
+
+        $this->assertEquals( $expected, $block_nodes );
     }