Changeset 59232 for trunk/tests/phpunit/tests/user.php

Timestamp:

10/14/2024 09:14:49 PM (16 months ago)

Author:

SergeyBiryukov

Message:

Users: Further adjust the check for use_ssl meta in wp_insert_user().

This removes a redundant check for a falsey value, which is equivalent to the empty() check directly before.

Includes minor adjustments in the unit test:

• Adding a @covers tag.
• Correcting the description for clarity.
• Using assertSame() for strict type checking.

Follow-up to [59216].

See #60299.

File:

• trunk/tests/phpunit/tests/user.php (modified) (3 diffs)

trunk/tests/phpunit/tests/user.php

@@ -2248 +2248 @@
 
     /**
-     * Test that update_user_meta for 'use_ssl' doesn't write to DB unnecessarily.
+     * Tests that wp_insert_user() does not unnecessarily update the 'use_ssl' meta.
      *
      * @ticket 60299
-     */
-    public function test_unnecessary_assignment_of_use_ssl_in_meta() {
+     *
+     * @covers ::wp_insert_user
+     */
+    public function test_wp_insert_user_should_not_unnecessary_update_use_ssl_meta() {
         $user_id = self::$contrib_id;
-        // Keep track of db writing calls.
-        $set_db_counts = 0;
-
-        // Track db updates with calls to do_action( "update_user_meta", ... with 'use_ssl' meta key.
+        // Keep track of database writing calls.
+        $db_update_count = 0;
+
+        // Track database updates via update_user_meta() with 'use_ssl' meta key.
         add_action(
             'update_user_meta',
-            function ( $meta_id, $object_id, $meta_key ) use ( &$set_db_counts ) {
+            function ( $meta_id, $object_id, $meta_key ) use ( &$db_update_count ) {
                 if ( 'use_ssl' !== $meta_key ) {
                     return;
                 }
-                $set_db_counts++;
+                $db_update_count++;
             },
             10,
@@ -2279 +2281 @@
 
         $this->assertIsInt( $user_id );
-        $this->assertEquals( 1, $set_db_counts );
+        $this->assertSame( 1, $db_update_count );
 
         // Update the user without changing the 'use_ssl' meta.
@@ -2285 +2287 @@
         $user_id        = edit_user( $user_id );
 
-        // Verify there are no updates to use_ssl user meta.
-        $this->assertEquals( 1, $set_db_counts );
+        // Verify there are no updates to 'use_ssl' user meta.
+        $this->assertSame( 1, $db_update_count );
     }
 }