Changeset 59243 for trunk/tests/phpunit/tests/feed/rssEnclosure.php

Timestamp:

10/16/2024 02:17:12 PM (7 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Correct test class name for rss_enclosure() as per the naming conventions.

Includes:

• Moving @covers tags to the class-level DocBlock, since this is the only function tested in the class.
• Adjusting the assertion messages for clarity, as rss_enclosure() does not return anything directly.
• Using a static closure for improved performance.

Follow-up to [59241].

See #61530.

File:

• trunk/tests/phpunit/tests/feed/rssEnclosure.php (modified) (10 diffs)

trunk/tests/phpunit/tests/feed/rssEnclosure.php

@@ -2 +2 @@
 
 /**
- * Test the feed.
+ * Tests for the rss_enclosure() function.
  *
  * @group feed
+ *
+ * @covers ::rss_enclosure
  */
-class Tests_rssEnclosure extends WP_UnitTestCase {
+class Tests_Feed_RssEnclosure extends WP_UnitTestCase {
+
     /**
      * @ticket 58798
-     *
-     * @covers ::rss_enclosure
      */
     public function test_rss_enclosure_filter() {
@@ -22 +23 @@
         add_filter(
             'rss_enclosure',
-            function () {
+            static function () {
                 return 'filtered_html_link_tag';
             }
@@ -32 +33 @@
     /**
      * @ticket 58798
-     *
-     * @covers ::rss_enclosure
      */
     public function test_rss_enclosure_when_global_post_is_empty() {
-        $this->assertEmpty( get_echo( 'rss_enclosure' ), 'It should return empty when the global post is not set.' );
+        $this->assertEmpty( get_echo( 'rss_enclosure' ), 'The output should be empty when the global post is not set.' );
     }
 
     /**
      * @ticket 58798
-     *
-     * @covers ::rss_enclosure
      */
     public function test_rss_enclosure_when_enclosure_meta_field_is_empty() {
@@ -48 +45 @@
         $GLOBALS['post'] = $post_id;
 
-        $this->assertEmpty( get_echo( 'rss_enclosure' ), 'The global post does not have the `enclosure` meta field and should return empty. ' );
+        $this->assertEmpty( get_echo( 'rss_enclosure' ), 'The output should be empty when the global post does not have the `enclosure` meta field.' );
     }
 
@@ -55 +52 @@
      *
      * @dataProvider data_rss_enclosure_with_multiline_enclosure_string
-     * @covers ::rss_enclosure
      */
     public function test_rss_enclosure_with_multiline_enclosure_string( $enclosure_data, $enclosure_string ) {
@@ -65 +61 @@
         $expected = '<enclosure url="' . $enclosure_data['url'] . '" length="' . $enclosure_data['length'] . '" type="' . $enclosure_data['type'] . '" />' . "\n";
 
-        $this->assertSame( $expected, get_echo( 'rss_enclosure' ), 'It should return a valid enclosure tag. ' );
+        $this->assertSame( $expected, get_echo( 'rss_enclosure' ), 'The output should be a valid enclosure tag.' );
     }
 
@@ -71 +67 @@
      * Data provider for valid enclosure string.
      *
-     * @return array[].
+     * @return array[]
      */
     public function data_rss_enclosure_with_multiline_enclosure_string() {
@@ -114 +110 @@
      *
      * @dataProvider data_rss_enclosure_with_non_valid_enclosure_string
-     * @covers ::rss_enclosure
      */
     public function test_rss_enclosure_with_non_valid_enclosure_string( $enclosure_string ) {
@@ -122 +117 @@
         update_post_meta( $post_id, 'enclosure', $enclosure_string );
 
-        $this->assertEmpty( get_echo( 'rss_enclosure' ), 'It should return empty when the `enclosure` meta field is not saved in a multiline string.' );
+        $this->assertEmpty( get_echo( 'rss_enclosure' ), 'The output should be empty when the `enclosure` meta field is not saved in a multiline string.' );
     }
 
@@ -128 +123 @@
      * Data provider for non-valid enclosure string.
      *
-     * @return array[].
+     * @return array[]
      */
     public function data_rss_enclosure_with_non_valid_enclosure_string() {