Context Navigation

← Previous Change
Next Change →

wpHtmlProcessor.php

Timestamp:

10/17/2024 05:46:31 PM (21 months ago)

Author:

Bernhard Reiter

Message:

HTML API: Ensure form closer tokens are reachable.

Form tag closers have complicated conditions. There was a bug where the HTML Processor would not stop correctly on a FORM tag closer token.
This changeset ensures that that token is reachable.

Developed in https://github.com/WordPress/wordpress-develop/pull/7582
Discussed in https://core.trac.wordpress.org/ticket/61576

Follow-up to [58779].

Props jonsurrell.
Fixes #61576.

File:

: 1 edited

trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php

-              r59099
+              r59248
                 );
+        }
+        /**
+         * Ensures that the processor stops correctly on a FORM tag closer token.
+         *
+         * Form tag closers have complicated conditions. There was a bug where the processor
+         * would not stop correctly on a FORM tag closer token. Ensure this token is reachable.
+         *
+         * @ticket 61576
+         */
+        public function test_ensure_form_tag_closer_token_is_reachable() {
+                $processor = WP_HTML_Processor::create_fragment( '<form></form>' );
+                // Advance to </form>.
+                $processor->next_token();
+                $processor->next_token();
+                $this->assertSame( 'FORM', $processor->get_tag() );
+                $this->assertTrue( $processor->is_tag_closer() );
+        }
+}

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 59248 for trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php

Legend:

trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php

Download in other formats: