Changeset 59288

Timestamp:

10/24/2024 11:58:02 PM (23 months ago)

Author:

SergeyBiryukov

Message:

Revisions: Set PHP time limit when generating revision diffs vis Ajax.

This aims to avoid hanging PHP processes if a plugin inadvertently attempts to request a large number of revision diffs.

Follow-up to [24520], [24707], [59039].

Props madpeter, lovesoni1999, debarghyabanerjee, pbearne, desrosj, SergeyBiryukov.
Fixes #49291.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (1 diff)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -3557 +3557 @@
         $return = array();
 
-        // Removes the script timeout limit by setting it to 0 allowing ample time for diff UI setup.
         if ( function_exists( 'set_time_limit' ) ) {
-                set_time_limit( 0 );
+                // Increase the script timeout limit to allow ample time for diff UI setup.
+                set_time_limit( 5 * MINUTE_IN_SECONDS );
         }