Changeset 59327

Timestamp:

10/30/2024 11:45:53 PM (5 weeks ago)

Author:

peterwilsoncc

Message:

Tests/Build tools: Only fail importer tests if plugin is missing.

Reverts an earlier change to the test suite in which the PHPUnit tests could not run if the importer plugin was not available.

This update allows the test suite to run and will fail importer tests if the plugin is not available.

Follow up to r59085.

Merges [59326] to the 6.7 branch.

Props peterwilsoncc, azaozz.
See #62325.

Location:

branches/6.7

Files:

• . (modified) (1 prop)
• tests/phpunit/includes/bootstrap.php (modified) (1 diff)
• tests/phpunit/tests/import/base.php (modified) (2 diffs)
• tests/phpunit/tests/import/import.php (modified) (1 diff)
• tests/phpunit/tests/import/parser.php (modified) (1 diff)
• tests/phpunit/tests/import/postmeta.php (modified) (1 diff)

branches/6.7/tests/phpunit/includes/bootstrap.php

@@ -217 +217 @@
 define( 'IMPORTER_PLUGIN_FOR_TESTS', DIR_TESTDATA . '/plugins/wordpress-importer/wordpress-importer.php' );
 
-if ( defined( 'WP_RUN_CORE_TESTS' ) && WP_RUN_CORE_TESTS && ! file_exists( IMPORTER_PLUGIN_FOR_TESTS ) ) {
-    echo 'The test suite requires the WordPress Importer plugin to be available in the `/data/plugins/` directory.'
-        . ' See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests' . PHP_EOL,
-    exit( 1 );
-}
-
 define( 'WP_LANG_DIR', realpath( DIR_TESTDATA . '/languages' ) );
 

branches/6.7/tests/phpunit/tests/import/base.php

@@ -2 +2 @@
 
 abstract class WP_Import_UnitTestCase extends WP_UnitTestCase {
+
+    /**
+     * Require the WordPress Importer plugin.
+     *
+     * Fails the test if the plugin is not installed.
+     */
+    protected function require_importer() {
+        if ( ! file_exists( IMPORTER_PLUGIN_FOR_TESTS ) ) {
+            $this->fail( 'This test requires the WordPress Importer plugin to be installed in the test suite. See: https://make.wordpress.org/core/handbook/contribute/git/#unit-tests' );
+        }
+        require_once IMPORTER_PLUGIN_FOR_TESTS;
+    }
+
     /**
      * Import a WXR file.
@@ -22 +35 @@
      */
     protected function _import_wp( $filename, $users = array(), $fetch_files = true ) {
+        $this->require_importer();
+
         $importer = new WP_Import();
         $file     = realpath( $filename );

branches/6.7/tests/phpunit/tests/import/import.php

@@ -22 +22 @@
         add_filter( 'import_allow_create_users', '__return_true' );
 
-        require_once IMPORTER_PLUGIN_FOR_TESTS;
+        $this->require_importer();
 
         // Crude but effective: make sure there's no residual data in the main tables.

branches/6.7/tests/phpunit/tests/import/parser.php

@@ -18 +18 @@
         }
 
-        require_once IMPORTER_PLUGIN_FOR_TESTS;
+        $this->require_importer();
     }
 

branches/6.7/tests/phpunit/tests/import/postmeta.php

@@ -20 +20 @@
         }
 
-        require_once IMPORTER_PLUGIN_FOR_TESTS;
+        $this->require_importer();
     }