Changeset 59337

Timestamp:

11/03/2024 11:01:38 PM (6 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Explicitly return false in magic __isset() methods.

This commit fixes an issue where some magic __isset() methods were potentially returning void (if the prop is not in an allow-listed array of fields) instead of an explicit boolean false.

Addressed methods:

• WP_Comment::__isset()
• WP_Query::__isset()

Follow-up to [28523], [31151], [34583], [34599].

Props justlevine.
See #52217.

Location:

trunk/src/wp-includes

Files:

• class-wp-comment.php (modified) (2 diffs)
• class-wp-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-comment.php

@@ -352 +352 @@
      * @since 4.4.0
      *
-     * @param string $name Property name.
-     * @return bool
+     * @param string $name Property to check if set.
+     * @return bool Whether the property is set.
      */
     public function __isset( $name ) {
@@ -360 +360 @@
             return property_exists( $post, $name );
         }
+
+        return false;
     }
 

trunk/src/wp-includes/class-wp-query.php

@@ -4012 +4012 @@
             return isset( $this->$name );
         }
+
+        return false;
     }