Changeset 5936

Timestamp:

08/24/2007 02:18:08 PM (17 years ago)

Author:

ryan

Message:

Fix how wp_filter array is keyed. Props santosj/darkdragon. fixes #3875 for 2.3

File:

• trunk/wp-includes/plugin.php (modified) (3 diffs)

trunk/wp-includes/plugin.php

@@ -20 +20 @@
 
     // So the format is wp_filter['tag']['array of priorities']['array of functions serialized']['array of ['array (functions, accepted_args)]']
-    $wp_filter[$tag][$priority][serialize($function_to_add)] = array('function' => $function_to_add, 'accepted_args' => $accepted_args);
+    $idx = _wp_filter_build_unique_id($tag, $function_to_add, $priority);
+    $wp_filter[$tag][$priority][$idx] = array('function' => $function_to_add, 'accepted_args' => $accepted_args);
+    //$wp_filter[$tag][$priority][serialize($function_to_add)] = array('function' => $function_to_add, 'accepted_args' => $accepted_args);
     unset( $merged_filters[ $tag ] );
     return true;
@@ -98 +100 @@
  */
 function remove_filter($tag, $function_to_remove, $priority = 10, $accepted_args = 1) {
-    $function_to_remove = serialize($function_to_remove);
+    $function_to_remove = _wp_filter_build_unique_id($tag, $function_to_remove, $priority);
 
     $r = isset($GLOBALS['wp_filter'][$tag][$priority][$function_to_remove]);
@@ -282 +284 @@
 }
 
+function _wp_filter_build_unique_id($tag, $function, $priority = 10)
+{
+    global $wp_filter;
+    
+    // If function then just skip all of the tests and not overwrite the following.
+    // Static Calling
+    if( is_string($function) )
+        return $function;
+    // Object Class Calling
+    else if(is_object($function[0]) )
+    {
+        $obj_idx = get_class($function[0]).$function[1];
+        if( is_null($function[0]->wp_filter_id) ) {
+            $count = count((array)$wp_filter[$tag][$priority]);
+            $function[0]->wp_filter_id = $count;
+            $obj_idx .= $count;
+            unset($count);
+        } else
+            $obj_idx .= $function[0]->wp_filter_id;
+        return $obj_idx;
+    }
+    else if( is_string($function[0]) )
+        return $function[0].$function[1];
+}
+
 ?>