Changeset 59383

Timestamp:

11/11/2024 05:53:40 PM (12 months ago)

Author:

desrosj

Message:

Feeds: Avoid fatal error with empty blog_charset value.

After the SimplePie library was updated to version 1.8.0 in [59141], an edge case has been discovered where a fatal error can encountered if the blog_charset option is missing or empty.

In fetch_feed(), this option is retrieved using get_option() instead of get_bloginfo( ‘charset’ ). The latter will detect this scenario and apply a default value of UTF-8 and is already used interchangeably throughout Core. This switches to get_bloginfo( ‘charset’ ) instead to prevent this edge case.

Reviewed by davidbaumwald.
Merges [59382] to the 6.7 branch.

Props david.binda, davidbaumwald, SergeyBiryukov, sabernhardt, azaozz, peterwilsoncc.
Fixes #62354.

Location:

branches/6.7

Files:

• . (modified) (1 prop)
• src/wp-includes/feed.php (modified) (1 diff)
• tests/phpunit/tests/feed/fetchFeed.php (copied) (copied from trunk/tests/phpunit/tests/feed/fetchFeed.php)

branches/6.7/src/wp-includes/feed.php

@@ -843 +843 @@
 
     $feed->init();
-    $feed->set_output_encoding( get_option( 'blog_charset' ) );
+    $feed->set_output_encoding( get_bloginfo( 'charset' ) );
 
     if ( $feed->error() ) {