Make WordPress Core

Changeset 59402


Ignore:
Timestamp:
11/13/2024 07:06:57 PM (3 months ago)
Author:
desrosj
Message:

Build/Test Tools: Avoid starting the database twice.

The database container is started when the services are initially set up. Having a separate step for this sometimes introduces unexpected failures for an unknown reason.

Props johnbillion.
See #62221.

Location:
trunk/.github/workflows
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/.github/workflows/install-testing.yml

    r59282 r59402  
    9797  # Performs the following steps:
    9898  # - Sets up PHP.
    99   # - Starts the database server.
    10099  # - Downloads the specified version of WordPress.
    101100  # - Creates a `wp-config.php` file.
     
    158157          tools: wp-cli${{ contains( fromJSON('["5.4", "5.5"]'), matrix.php ) && ':2.4.0' || '' }}
    159158
    160       - name: Start the database server
    161         run: |
    162           sudo systemctl start ${{ matrix.db-type }}
    163 
    164159      - name: Download WordPress
    165160        run: wp core download ${{ inputs.wp-version && format( '--version={0}', inputs.wp-version ) || '--version=nightly' }}
  • trunk/.github/workflows/reusable-upgrade-testing.yml

    r59280 r59402  
    4343  # Performs the following steps:
    4444  # - Sets up PHP.
    45   # - Starts the database server.
    4645  # - Downloads the specified version of WordPress.
    4746  # - Creates a `wp-config.php` file.
     
    6968          -c "exec docker-entrypoint.sh mysqld${{ inputs.db-type == 'mysql' && contains( fromJSON('["7.2", "7.3"]'), inputs.php ) && ' --default-authentication-plugin=mysql_native_password' || '' }}"
    7069
    71 
    7270    steps:
    7371      - name: Set up PHP ${{ inputs.php }}
     
    7775          coverage: none
    7876          tools: wp-cli
    79 
    80       - name: Start the database server
    81         run: |
    82           sudo systemctl start ${{ inputs.db-type }}
    8377
    8478      - name: Download WordPress ${{ inputs.wp }}
Note: See TracChangeset for help on using the changeset viewer.