Changeset 59404 for branches/6.7

Timestamp:

11/14/2024 11:53:57 AM (22 months ago)

Author:

cbravobernal

Message:

Interactivity API: Allow missing state negation on server

Aligns on the behavior of the negation operator with directives to missing paths in client and in server.

With a directive like the following:

<div data-wp-bind--hidden="!state.missing.property">
	This should be hidden by the <code>hidden</code> attribute.
</div>

Both server and client will return with this fix:

<div data-wp-bind--hidden="!state.missing.property" hidden="">
	This should be hidden by the <code>hidden</code> attribute.
</div>

Reviewed by cbravobernal.
Merges [59398] to the 6.7 branch.

Props jonsurrell, luisherranz.
Fixes #62374.

Location:

branches/6.7

Files:

• . (modified) (1 prop)
• src/wp-includes/interactivity-api/class-wp-interactivity-api.php (modified) (1 diff)
• tests/phpunit/tests/interactivity-api/wpInteractivityAPI.php (modified) (1 diff)

branches/6.7/src/wp-includes/interactivity-api/class-wp-interactivity-api.php

@@ -585 +585 @@
                                 $current = $current->$path_segment;
                         } else {
-                                return null;
+                                $current = null;
+                                break;
                         }
 

branches/6.7/tests/phpunit/tests/interactivity-api/wpInteractivityAPI.php

@@ -1081 +1081 @@
 
         /**
+         * Tests that the `evaluate` method operates correctly when used with the
+         * negation operator (!) with non-existent paths.
+         *
+         * @ticket 62374
+         *
+         * @covers ::evaluate
+         */
+        public function test_evaluate_value_negation_non_existent_path() {
+                $this->interactivity->state( 'myPlugin', array() );
+                $this->interactivity->state( 'otherPlugin', array() );
+                $this->set_internal_context_stack(
+                        array(
+                                'myPlugin'    => array(),
+                                'otherPlugin' => array(),
+                        )
+                );
+                $this->set_internal_namespace_stack( 'myPlugin' );
+
+                $result = $this->evaluate( '!state.missing' );
+                $this->assertTrue( $result );
+
+                $result = $this->evaluate( '!context.missing' );
+                $this->assertTrue( $result );
+
+                $result = $this->evaluate( 'otherPlugin::!state.deeply.nested.missing' );
+                $this->assertTrue( $result );
+
+                $result = $this->evaluate( 'otherPlugin::!context.deeply.nested.missing' );
+                $this->assertTrue( $result );
+        }
+
+        /**
          * Tests the `evaluate` method with non-existent paths.
          *