Changeset 59423

Timestamp:

11/19/2024 08:21:31 PM (4 months ago)

Author:

desrosj

Message:

Media: Avoid running expensive logic twice using GD.

Support for uploading AVIF was added in [57524]. A new block of conditional logic was added determine which function should be used to create the new image file that resulted in these expensive functions being run twice.

This combines the two conditional logic to ensure the appropriate function is only run once regardless of format.

Reviewed by adamsilverstein.
Merges [59413] to the 6.7 branch.

Props adamsilverstein, glynnquelch.
Fixes #62331.

Location:

branches/6.7

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-image-editor-gd.php (modified) (1 diff)

branches/6.7/src/wp-includes/class-wp-image-editor-gd.php

@@ -104 +104 @@
         }
 
-        // WebP may not work with imagecreatefromstring().
+        // Handle WebP and AVIF mime types explicitly, falling back to imagecreatefromstring.
         if (
-            function_exists( 'imagecreatefromwebp' ) &&
-            ( 'image/webp' === wp_get_image_mime( $this->file ) )
+            function_exists( 'imagecreatefromwebp' ) && ( 'image/webp' === wp_get_image_mime( $this->file ) )
         ) {
             $this->image = @imagecreatefromwebp( $this->file );
-        } else {
-            $this->image = @imagecreatefromstring( $file_contents );
-        }
-
-        // AVIF may not work with imagecreatefromstring().
-        if (
-            function_exists( 'imagecreatefromavif' ) &&
-            ( 'image/avif' === wp_get_image_mime( $this->file ) )
+        } elseif (
+            function_exists( 'imagecreatefromavif' ) && ( 'image/avif' === wp_get_image_mime( $this->file ) )
         ) {
             $this->image = @imagecreatefromavif( $this->file );